Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support paginated provider #17

Merged
merged 5 commits into from
Sep 27, 2021
Merged

Support paginated provider #17

merged 5 commits into from
Sep 27, 2021

Conversation

roborourke
Copy link
Contributor

tfrommen
tfrommen reviewed Sep 20, 2021
View reviewed changes
inc/class-provider.php Outdated Show resolved Hide resolved
inc/class-provider.php Show resolved Hide resolved
inc/class-provider.php Outdated Show resolved Hide resolved
@roborourke roborourke marked this pull request as draft September 20, 2021 16:23
@roborourke roborourke marked this pull request as ready for review September 22, 2021 15:52
tfrommen
tfrommen approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@tfrommen tfrommen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Just noting that this does require using the new AMF release, though. Maybe you want to update this in here?

@roborourke roborourke merged commit dc2ca53 into main Sep 27, 2021
@roborourke roborourke deleted the updated-for-pagination branch September 27, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfrommen tfrommen tfrommen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roborourke @tfrommen