Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a skale maintainer and verify all the steps have been done #139

Closed
9 tasks
posix4e opened this issue Apr 5, 2022 · 62 comments
Closed
9 tasks

Get a skale maintainer and verify all the steps have been done #139

posix4e opened this issue Apr 5, 2022 · 62 comments
Assignees
Labels
enhancement New feature or request

Comments

@posix4e
Copy link
Contributor

posix4e commented Apr 5, 2022

The skale implementation has already had a good deal of work done for it

humanprotocol/hmt-escrow#261
humanprotocol/hmt-escrow@5357df3

So please build on top of this.

HMT-Escrow supports arbitrary EVM networks but there's a bit of work to do to make a network first class and make sure that it works. All of our EVM network launches are supported by gitcoin but you can gain a yearly bonus by being our network sponsor.

Steps to receive gitcoin bounty

  • Launch the contracts on the devnet and make sure that everything is working
  • Launch contracts on production network and file a commit with all the contract information to this repo's documentation. Here's an example Add polygon contract info hmt-escrow#296
  • Launch KVstore contracts https://github.com/humanprotocol/eth-kvstore
  • Add the contracts to the relevant network scanner (etherscan equivalent)
  • Launch a working app on the network. The easiest one to get going is our example fortune. https://github.com/humanprotocol/fortune Make a video of the functionality of the app working on the new network and link to relevant scanner transactions.
  • Add to human dashboard [ https://dashboard.humanprotocol.org/ ]
  • Request to become the maintainer for your EVM network. We will list you on our repo, give you an extra reward (generally around 1 ETH per year) and invite you to conferences. We will celebrate your name forever!
  • Verify bridging of tokens works

High level rules to make sure that you are doing this correctly

  • We never want to create a mintable token. Your change should not change the total token supply from 1 billion
@posix4e posix4e assigned posix4e and AndreasSchemm and unassigned posix4e and AndreasSchemm Apr 5, 2022
@posix4e
Copy link
Contributor Author

posix4e commented Apr 8, 2022

if you need support please join tech-discussions on the human protocol discord at hmt.ai

@posix4e
Copy link
Contributor Author

posix4e commented Apr 12, 2022

When deploying production contracts use a dedicated wallet with a seed phrase you don't use anywhere else. You might be required to share it with us.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.0 ETH (2864.64 USD @ $2864.64/ETH) attached to it.

@posix4e
Copy link
Contributor Author

posix4e commented May 5, 2022

how is it going

@posix4e
Copy link
Contributor Author

posix4e commented May 9, 2022

@weakpasscode. Any updates?

@posix4e posix4e removed their assignment May 10, 2022
@weakpasscode
Copy link

yes, tsrating with deployment on optimism testnet

@posix4e
Copy link
Contributor Author

posix4e commented May 12, 2022

amazing. How are you planning on bridging the tokens?

@foufrix
Copy link
Contributor

foufrix commented Jul 11, 2022

Hi @weakpasscode,
Is everything good on your side? Did you manage to make progress on this task? If you need any help don't hesitate to reach out here or on Discord

@weakpasscode
Copy link

connecting you on discord, I was stuck on bridging token part

@foufrix
Copy link
Contributor

foufrix commented Jul 21, 2022

Hi @weakpasscode any progress on this task?

@gitcoinbot
Copy link

gitcoinbot commented Aug 4, 2022

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 3 months from now.
Please review their action plans below:

1) azizbardi has been approved to start work.

Hello,
i am looking forward to join as a maintainer and tester. i already worked on HMT escrow and ETH escrow and tested it with Skale network , and right now i am on the fortune app trying to solve a quick issue with Metamask transaction comfirmation :)) excited to get my hands on these challenges :)

Learn more on the Gitcoin Issue Details page.

@AzizBardi
Copy link
Contributor

Hello,
I have deployed skale testnet on both projects. Will upload my work and some screenshots 😊

@foufrix
Copy link
Contributor

foufrix commented Aug 9, 2022

Hi @AzizBardi, do you have any updates on this? If you can give us the state of where you are every three days even if it's small steps so that we know where you at and when we can expect a full release

@AzizBardi
Copy link
Contributor

Hi @AzizBardi, do you have any updates on this? If you can give us the state of where you are every three days even if it's small steps so that we know where you at and when we can expect a full release

Hello @foufrix , i am one step from finishing all the tasks. I am just finishing with the fortune app, but i am having today a call woth @Jalal-1 to discuss about it :) (fortune app)
I will leave a message this week as soon that everything is complete :D

@foufrix
Copy link
Contributor

foufrix commented Aug 9, 2022

This is awesome, thank you @AzizBardi for the quick update 🙏

@AzizBardi
Copy link
Contributor

This is awesome, thank you @AzizBardi for the quick update 🙏

@foufrix thanks 😀

@AzizBardi
Copy link
Contributor

Update:
Task related to eth-kvstore and hmt-escrow are done, only fortune app is still not working correctly.

eth-KVstore ( Works on the skale network )

Issue is encountred:

  • Missing "Dockerfile" while running docker-compose build
    ethkvstore3

I managed to run the project on the Skale Network with localrun.

Generated Json file is:
ethkvstore.address.zip

hmt-escrow (Works on the skale network)

-Issue i encountred
the pipfile.lock instalation is not working (this is some screenshots)

this is the pre modified one:
Pipfileold.zip

hmtescrowissue

this is the pipfile.lock after the updates (working)
Pipfile.zip

Fortune App
-issue encountred
the create escrow event doesn't work , i think that the HMT token on the metamask is always zero value so the transaction cannot create the escrow. Missed part on the documentation (i am having a call this weekend with @jalal and will figure this out )

these are some screenshots

fortuneappissue

fortuneappissue2

@foufrix
Copy link
Contributor

foufrix commented Aug 13, 2022

Hi @AzizBardi , thank you for the feedback

For the fortune app, does the factory address match the hmt-escrow contract address you deployed on scale ? Can you send the contracts address you deployed on skale?

@AzizBardi
Copy link
Contributor

@foufrix for the fortune app, i am working with the address found on the readme. After making it running and working i will then add the skale network.

@foufrix
Copy link
Contributor

foufrix commented Aug 13, 2022

@AzizBardi this is where your problem is
If you are doing that only locally, you need to deploy the contract on your local ganache chain, what you are doing currently is starting the chain with no contract deployed on it and trying to interact with, the fortune app does not work because it's trying to access a contract that is 'ot deployed.

After that when you managed to make it work locally, you need to change this contract address to reflect the one deployed on skale when trying fortune app on skale network.

Hope it's clear

@AzizBardi
Copy link
Contributor

@foufrix okey, yes that sounds logic i will try and let you know. I have a call with @Jalal-1 to discuss more about the fortune app.
Thanks for the reply ! 😀

@AzizBardi
Copy link
Contributor

@AzizBardi this is where your problem is If you are doing that only locally, you need to deploy the contract on your local ganache chain, what you are doing currently is starting the chain with no contract deployed on it and trying to interact with, the fortune app does not work because it's trying to access a contract that is 'ot deployed.

After that when you managed to make it work locally, you need to change this contract address to reflect the one deployed on skale when trying fortune app on skale network.

Hope it's clear

The steps i do :
docker-compose up and on the other terminal cd contracts && yarn && yarn deploy

everything is working good but on metamask HMT token is always zero value

the wallet i am using is already found on the project
ETH_PRIVATE_KEY 657b6497a355a3982928d5515d48a84870f057c4d16923eb1d104c0afada9aa8

@AzizBardi
Copy link
Contributor

AzizBardi commented Aug 13, 2022

All good now, thanks to @Jalal-1 !
the issue was not deleting the old docker image files haha

Screenshot from 2022-08-13 19-24-13

Screenshot from 2022-08-13 18-57-57

@AzizBardi
Copy link
Contributor

Hello,
So regarding the issue, we did a bridging solution with IMA(I can send txs as a proof)
And said that we are ready to setup for mainnet chain for HP.

Can i have Human Protocol thumbs up for this?

@foufrix
Copy link
Contributor

foufrix commented Nov 24, 2022

@AzizBardi Awesome news !!
Can you provide :

  • the bridge contract ? It's on mainnet or testnet ?
  • ethkvstore contract on testnet
  • EscrowFactory on testnet

A video & txids of fortune working on testnet

Once we have that we can send you HMT on Polygon to bridge to Skale & what's needed for deployment on contract on skale mainnet

@AzizBardi
Copy link
Contributor

hello,
i provided a month ago ethkvstore with contract, escrowFactory, and fortune app working on testnet, and you told me that this is nice but we only need mainnet.. so is it okey to continue on testnet or what ? ...

@foufrix
Copy link
Contributor

foufrix commented Nov 25, 2022

No No it's good for testnet perfect. Do you have the address of the bridge for HMT deployed on skale?

I'll put you in contact with @ansaqib so that you have MATIC, HMT & SKALE token for deployment on mainnet

@AzizBardi
Copy link
Contributor

Yes IMA bridge(provided by SKALE) is launched on mainnet and testnet, IMA bridge support all ERC20 tokens, so it is possible to bridge HMT to SKALE chain.

Bridge txs and tokens on testnet:
HMT Token on Goerli:
https://goerli.etherscan.io/token/0xd3a31d57fdd790725d0f6b78095f62e8cd4ab317
HMT Token on schain:
https://staging-perfect-parallel-gacrux.explorer.staging-v3.skalenodes.com/token/0x635197501e5a85eC13a17c9c500cFdB32EC32d2f/token-transfers

Deposit 1 HMT tx on Goerli: https://goerli.etherscan.io/tx/0x6bbb4a94a146fc921bc89671ee855b5fcf9802c71dbb2a8d1b96c3c5b54a4083
Receiving 1 HMT tx on schain:
https://staging-perfect-parallel-gacrux.explorer.staging-v3.skalenodes.com/tx/0x9061ba6ac849174ff9ce6e387c28a6ec1b32d95268888c7b20cf8494968a072e/token-transfers

IMA contract for ERC20 tokens(DepositBoxERC20) on mainnet:
https://etherscan.io/address/0x8fB1A35bB6fB9c47Fb5065BE5062cB8dC1687669

IMA contract for ERC20 tokens(DepositBoxERC20) on tesnet:
https://goerli.etherscan.io/address/0x2F4B31e661955d41bd6ab5530b117758C26C8159

@AzizBardi
Copy link
Contributor

Hello,

this is a video about the fortune app running on skale network (final staging test before mainnet) with skale hmt token.
you can check the transactions on this link :

https://staging-perfect-parallel-gacrux.explorer.staging-v3.skalenodes.com/address/0x635197501e5a85eC13a17c9c500cFdB32EC32d2f/transactions

this is the address and the skale network i am using :

URL: https://staging-v3.skalenodes.com/v1/staging-perfect-parallel-gacrux
HMT Token on Goerli: 0xd3A31D57FDD790725d0F6B78095F62E8CD4ab317
HMT Token on schain: 0x635197501e5a85eC13a17c9c500cFdB32EC32d2f

this is the video for further informations:

fortuneappskalenetwork.zip

Will keep you updated next week for the mainnet !

Thanks everyone !

@foufrix
Copy link
Contributor

foufrix commented Dec 22, 2022

Thank you @AzizBardi, looking forward for mainnet !! 👏 🚀

For your submission of mainnet, please follow this template so that it's easier to review for the Human Protocol Team: humanprotocol/hmt-escrow#335 (comment)

@portuu3 portuu3 transferred this issue from humanprotocol/hmt-escrow Jan 5, 2023
@portuu3 portuu3 added the enhancement New feature or request label Jan 5, 2023
@foufrix
Copy link
Contributor

foufrix commented Jan 9, 2023

Hi @AzizBardi, happy new year! Do you have news on the skale mainnet deployment?

@AzizBardi
Copy link
Contributor

Hi @foufrix happy new year ! :D
Skale team is having meeting woth Human Protocol but normally i will update you for the last implementation of the main net.

@AzizBardi
Copy link
Contributor

Hello,
So I just made a pull request and as I saw it was approved,
humanprotocol/hmt-escrow#451
I wanted to ask if there is anything missing, or if I need to do something else.
everything is done except for the graph node I will soon give you an update.

@foufrix
Copy link
Contributor

foufrix commented Feb 6, 2023

Hi @AzizBardi thank you for your contribution,

Can you send all those information like this comment: humanprotocol/hmt-escrow#335

So that it can be reviewed easily by the human protocol team?

@AzizBardi
Copy link
Contributor

Hi @AzizBardi thank you for your contribution,

Can you send all those information like this comment: humanprotocol/hmt-escrow#335

So that it can be reviewed easily by the human protocol team?

Sure thing !

@AzizBardi
Copy link
Contributor

Hello,
All steps have been done, please find below the necessary informations.

Thanks

@foufrix
Copy link
Contributor

foufrix commented Feb 14, 2023

Hi @AzizBardi thanks for the contribution, @portuu3 @ansaqib is there all you need ?
One thing @AzizBardi this PR humanprotocol/hmt-escrow#451 should be reported to this repo: https://github.com/humanprotocol/human-protocol as hmt-escrow has been migrated and the repo you commit to is deprecated

@portuu3
Copy link
Collaborator

portuu3 commented Feb 14, 2023

@foufrix I will review

@AzizBardi
Copy link
Contributor

@foufrix i will do the necessary changes in the new repo but I thought the hmt escrow is the repo I am working on. will merge the pull request to the other repo :)

@portuu3
Copy link
Collaborator

portuu3 commented Feb 16, 2023

@AzizBardi let me know when the PRs is ready and I will review

@AzizBardi
Copy link
Contributor

@AzizBardi let me know when the PRs is ready and I will review

PR is ready here humanprotocol/hmt-escrow#451
But i will merge it to the other branch like foufrix mentioned

@portuu3
Copy link
Collaborator

portuu3 commented Feb 16, 2023

@AzizBardi let me know when the PRs is ready and I will review

PR is ready here humanprotocol/hmt-escrow#451 But i will merge it to the other branch like foufrix mentioned

I mean the PR in this repo https://github.com/humanprotocol/human-protocol

@AzizBardi
Copy link
Contributor

@portuu3 #259
pull request Done, looking forward to the approval and to talking with you !😃

@AzizBardi
Copy link
Contributor

@foufrix @portuu3 pull request done ! :D
#259

Looking forward for the approval ! 🙋🏻‍♂️🥳

@foufrix
Copy link
Contributor

foufrix commented Mar 6, 2023

@AzizBardi portuu is currently in vacactions and will get back to you when he gets back 🙏

@AzizBardi
Copy link
Contributor

@AzizBardi portuu is currently in vacactions and will get back to you when he gets back 🙏

Do you have an idea when he will gets back ?

@AzizBardi
Copy link
Contributor

@foufrix @portuu3 this is an updated pull request (cleaner version)
#287
thanks

@AzizBardi
Copy link
Contributor

Hello @posix4e @portuu3 PR was merged, i just want to know what is next now ? :)

@ansaqib ansaqib closed this as completed Mar 24, 2023
portuu3 pushed a commit that referenced this issue Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Merged and Paid
Development

No branches or pull requests

9 participants