Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hum 39 click on human app logo should redirect to default page #2678

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

KacperKoza343
Copy link
Contributor

Description

HUM-39

Copy link

vercel bot commented Oct 22, 2024

@KacperKoza343 is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@KacperKoza343 KacperKoza343 force-pushed the HUM-39-click-on-human-app-logo-should-redirect-to-default-page branch from a698156 to 8a21153 Compare October 23, 2024 11:58
Copy link

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we have multiple components for mobile logo, but it's not related to this PR.

Main change lgtm, some minor cleanups and should be good to go

@KacperKoza343 KacperKoza343 force-pushed the HUM-39-click-on-human-app-logo-should-redirect-to-default-page branch from 5c8854e to 9c15b2c Compare October 25, 2024 12:37
@KacperKoza343
Copy link
Contributor Author

KacperKoza343 commented Oct 25, 2024

Not sure why we have multiple components for mobile logo, but it's not related to this PR.

Main change lgtm, some minor cleanups and should be good to go

cleanups done

@dnechay dnechay self-requested a review October 25, 2024 15:04
Copy link

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general

One question about padding before approve

<Stack alignItems="flex-start" sx={{ paddingLeft: '26px' }}>
<Stack
alignItems="flex-start"
sx={{ paddingLeft: '60px', cursor: 'pointer' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be 60px?

Looks a bit too much in comparison to design
Screenshot 2024-10-25 at 18 47 08
Screenshot 2024-10-25 at 18 47 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants