Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customization tools #97

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

Bravewarrior0
Copy link

@Bravewarrior0 Bravewarrior0 commented Aug 9, 2020

Hello,
I have added more variables that help to customize the search bar,location pin, FABs, icons and result card,
resultCardDecoration has been removed as it wasn't used at all, as card widget can't use decoration,
I hope U add those changes to the new version and thank you for the great library.

Now the branch has been updated due to the new languages feature

@diego-lipinski-de-castro

Was looking for this, I will be using directly from ur branch for now, I hope this get accept son

@diego-lipinski-de-castro

Is it possible to make the search bar box customizable? It looks off, its not centered and has a lot of not needed margin

@Bravewarrior0
Copy link
Author

Is it possible to make the search bar box customizable? It looks off, its not centered and has a lot of not needed margin

Thanks for your support! I will try to add it ASAP but I'm kinda busy right now, so feel free to fork it if you are in hurry.

@youseff7
Copy link

youseff7 commented Sep 2, 2020

how I can use this one?

@Bravewarrior0
Copy link
Author

how I can use this one?

You can easily add it to pubspec.yaml as

google_map_location_picker:
git:
url: https://github.com/Bravewarrior0/google_map_location_picker

@youseff7
Copy link

youseff7 commented Sep 3, 2020

I appreciate your help. But, I got an error :
`/C:/flutter/.pub-cache/git/google_map_location_picker-ebe1fc0a6dd942dd7052189921ddb65445f14313/lib/src/google_map_location_picker.dart:541:11: Error: No named parameter with the name 'resultCardDecoration'.
resultCardDecoration: resultCardDecoration,
^^^^^^^^^^^^^^^^^^^^
/C:/flutter/.pub-cache/git/google_map_location_picker-ebe1fc0a6dd942dd7052189921ddb65445f14313/lib/src/google_map_location_picker.dart:21:3: Context: Found this candidate, but the arguments don't match.
LocationPicker(
^^^^^^^^^^^^^^

FAILURE: Build failed with an exception.

  • Where:
    Script 'C:\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 896

  • What went wrong:
    Execution failed for task ':app:compileFlutterBuildDebug'.

Process 'command 'C:\flutter\bin\flutter.bat'' finished with non-zero exit value 1

  • Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

  • Get more help at https://help.gradle.org

BUILD FAILED in 30s
Exception: Gradle task assembleDebug failed with exit code 1
`

@Bravewarrior0
Copy link
Author

Hi that happened due to the version update
I have solved the conflict for now but I can not support it with each new version @humazed make

@youseff7
Copy link

youseff7 commented Sep 3, 2020

Thanks man you really save my time. If you don't mind I have a question. how I can fork your code? and Thanks again

@Bravewarrior0
Copy link
Author

Thanks man you really save my time. If you don't mind I have a question. how I can fork your code? and Thanks again

go to my repo https://github.com/Bravewarrior0/google_map_location_picker then click on fork
after that u can submit your own updates

Now u may notice that there is another conflict due to the new update

@Miamoto-Musashi
Copy link

@humazed is there a reason why this PR is not merged? if so can you pls explain?
would be very usefull thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants