Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accidental display in **mens #868

Open
craigsapp opened this issue Jan 2, 2024 · 1 comment
Open

Accidental display in **mens #868

craigsapp opened this issue Jan 2, 2024 · 1 comment
Assignees
@craigsapp

Comments

@craigsapp
Copy link
Member

Accidentals within the key signature are showing on notes, but they should be hidden (unless explicitly shown).

Example:

Screenshot 2024-01-02 at 11 55 03 AM

The flat in front of B3 should not be there.

Test data:

**mens
*clefC3
*k[b-]
=
Sc
SB-
Sc
=
*-
@craigsapp craigsapp self-assigned this Jan 2, 2024
craigsapp added a commit to rism-digital/verovio that referenced this issue Jan 3, 2024
@craigsapp
Implementation for issue humdrum-tools/verovio-humdrum-viewer#868
ee2f51d
@craigsapp
Copy link
Member Author

Implemented in commit rism-digital/verovio@ee2f51d

Now renders as:

Screenshot 2024-01-02 at 10 49 49 PM

craigsapp added a commit to craigsapp/humlib that referenced this issue Jan 8, 2024
@craigsapp
Temporary implementation for issue humdrum-tools/verovio-humdrum-view…
5701c5e 
…er#868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craigsapp craigsapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craigsapp