Slow preview animation #64
Conversation
…th opacity from 0.1 to 1 in 2.45s; after the slides are initiated transition pushed on to 0.57s
UtmostCreator
force-pushed
the
smoothPreviewAnimation
branch
from
6238fd0
to
116a9d6
Compare
resources/js/gallery.js
Outdated
| @@ -57,6 +57,13 @@ humhub.module('gallery', function (module, require, $) { | |||
| }); | |||
| }; | |||
|
|
|||
| $('#gallery-media-container .panel-body').one('click', function() { | |||
There was a problem hiding this comment.
Note that the gallery.js is only loaded once, so this event handler won't be attached when leaving and reentering the gallery view. Such handlers should be attached within the init function.
There was a problem hiding this comment.
Oh, thank you, @buddh4!
Yeah, for sure, you are right!
I will fix it (by moving this part to init function) today a bit later.
|
I fixed this, But I was needed to add some extra code to the main repo file: I you will have time try to swtich to another gallery and then go back to see that sometimes the transition did not take place, any ideas? |
UtmostCreator
force-pushed
the
smoothPreviewAnimation
branch
from
2f89d54
to
85bb06f
Compare
…hub.ui.gallery.js file
|
Most of the code has been moved to I have noticed that .slide-loading class does not work properly; So I believe it was broken somehow at some point because the spinner (which before did not spin around) and even if I add my class with CSS rotation, it does not snip, however, it does work outside of this class. I would appreciate any ideas if this loader is needed. |
|
For me the loader animation works fine, once I click on an gallery image a loader appears until the image is loaded. The spinner should look like the default spinner at: https://blueimp.github.io/Gallery/ Can you recreate your problem in the community?
|
|
Here is the issues url What should I do next? Please let me know it. |
Commit message "feat: slow appearing of the first image in the image preview added with opacity from 0.1 to 1 in 2.45s; after the slides are initiated transition pushed on to 0.57s"