Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show legal pages to check just after saving the configuration #62

Closed
marc-farre opened this issue Jun 27, 2023 · 2 comments
Closed

Show legal pages to check just after saving the configuration #62

marc-farre opened this issue Jun 27, 2023 · 2 comments

Comments

@marc-farre
Copy link
Contributor

If, in the configuration, you check e.g. "Terms and Conditions", you think you will have to check the terms page.
But because the session for Events::SESSION_KEY_LEGAL_CHECK is already checked, it doesn't happen, and you think it doesn't work.
Proposal: remove the session after configuration saving.
@marc-farre marc-farre changed the title Show legals page to check just after saving the configuration Show legal pages to check just after saving the configuration Jun 27, 2023
marc-farre added a commit to cuzy-app/humhub-modules-fork-legal that referenced this issue Jun 27, 2023
@marc-farre
Enh humhub#62: Show legal pages to check just after saving the config…
27ed86a 
…uration
@marc-farre marc-farre mentioned this issue Jun 27, 2023
Merged
@marc-farre
Copy link
Contributor Author

@luke- PR #63

luke- added a commit that referenced this issue Jun 27, 2023
@luke-
Merge pull request #63 from cuzy-app/remove-checked-session-on-config…
da2519b 
…-save

Enh #62: Show legal pages to check just after saving the configuration
@luke-
Copy link
Collaborator

luke- commented Jun 27, 2023

@funkycram Thanks!

@luke- luke- closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luke- @marc-farre