Merge pull request #122 from humhub/fix/40-hard-delete-on-disable-module

Hard delete records on disable module
humhub · May 1, 2023 · a75abbe · a75abbe
2 parents 9e1cb62 + 6c700df
commit a75abbe
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/Module.php b/Module.php
@@ -52,7 +52,7 @@ public function getContentContainerTypes()
     public function disable()
     {
         foreach (Poll::find()->all() as $poll) {
-            $poll->delete();
+            $poll->hardDelete();
         }
 
         parent::disable();
@@ -64,7 +64,7 @@ public function disable()
     public function disableContentContainer(ContentContainerActiveRecord $container)
     {
         foreach (Poll::find()->contentContainer($container)->all() as $poll) {
-            $poll->delete();
+            $poll->hardDelete();
         }
 
         parent::disableContentContainer($container);

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -1,6 +1,10 @@
 Changelog
 =========
 
+1.3.0 (May 1, 2023)
+-------------------
+- Fix #122: Hard delete records on disable module
+
 1.2.2 (Unreleased)
 -------------------------
 - Fix #117: Fix responsive layout bug

diff --git a/module.json b/module.json
@@ -3,9 +3,9 @@
     "name": "Polls",
     "description": "Easy to use poll system",
     "keywords": ["poll", "voting", "decision making"],
-    "version": "1.2.2",
+    "version": "1.3.0",
     "humhub": {
-        "minVersion": "1.13"
+        "minVersion": "1.14"
     },
     "homepage": "https://github.com/humhub/polls",
     "authors": [
@@ -20,8 +20,8 @@
         }
     ],
     "screenshots": [
-        "assets/screen1.PNG", 
-        "assets/screen2.PNG", 
+        "assets/screen1.PNG",
+        "assets/screen2.PNG",
         "assets/screen3.PNG",
         "assets/screen4.PNG"
     ]