Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh: Implement Profile Polls #58

Closed
wants to merge 5 commits into from
Closed

Conversation

ArchBlood
Copy link

@ArchBlood ArchBlood commented Nov 7, 2019

Can I get a look over @luke-?

@buddh4
Copy link
Contributor

buddh4 commented Feb 22, 2020

I've checked the Active developements and saw this thinking its an issue not a pull request, so I did implement it instead of reviewing your PR. Nontheless here is my feedback regarding your PR:

  • I did not fix the friend group in the create poll permission
  • You've forgotten to return the create poll permission for users in Module::getPermissions, which would make the permission not editable on profile level (perhaps this was intended)
  • Added feature to changelog

cd81cee

Otherwise you PR looks great, thanks for the effort!

@buddh4 buddh4 closed this Feb 22, 2020
@ArchBlood ArchBlood deleted the patch-1 branch February 23, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants