Merge pull request #74 from humhub/fix/198-integrity-check-memory-usage

Fix memory usage on integrity check
humhub · Nov 16, 2023 · 632a89b · 632a89b
2 parents 72b9deb + 0938481
commit 632a89b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Events.php b/Events.php
@@ -83,7 +83,7 @@ public static function onIntegrityCheck($event)
     {
         $integrityController = $event->sender;
         $integrityController->showTestHeadline("ReportContent Module (" . ReportContent::find()->count() . " entries)");
-        foreach (ReportContent::find()->joinWith('content')->all() as $rc) {
+        foreach (ReportContent::find()->joinWith('content')->each() as $rc) {
             if ($rc->content === null) {
                 if ($integrityController->showFix("Deleting report id " . $rc->id . " without existing content!")) {
                     $rc->delete();

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -5,6 +5,7 @@ Changelog
 ----------------------
 - Enh #71: Tests for `next` version
 - Fix #72: Fix error on open old notification
+- Fix #74: Fix memory usage on integrity check
 
 1.0.3 (July 10, 2023)
 ---------------------