Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test dependency to fix linking error in unit tests #504

Conversation

JonPulfer
Copy link
Contributor

I was getting a linking error when trying to run the unit tests. Adding this dependency to HummingbirdRouter fixed that error.

Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why CI never caught this. Can you run Nick Lockwood's swiftformat on this change.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (e78cde7) to head (368320f).
Report is 94 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   84.86%   83.01%   -1.86%     
==========================================
  Files          98       94       -4     
  Lines        5320     4280    -1040     
==========================================
- Hits         4515     3553     -962     
+ Misses        805      727      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonPulfer
Copy link
Contributor Author

For some reason, swiftformat in Xcode creates a suspiciously large changes to the formatting of the white space in the file. Running swiftformat on the CLI just updates the whitespace on the line I changed. I have swiftformat v0.53.8 installed.

@adam-fowler adam-fowler merged commit db1024c into hummingbird-project:main Jul 4, 2024
6 of 7 checks passed
@adam-fowler
Copy link
Member

thank you for this

@JonPulfer JonPulfer deleted the JonPulfer/fix_unit_test_linking_error branch July 6, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants