Metrics and Logging name changes #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoven87
reviewed
Sep 8, 2024
thoven87
reviewed
Sep 8, 2024
Joannis
reviewed
Sep 8, 2024
| @@ -102,7 +102,7 @@ extension ApplicationProtocol { | |||
| eventLoopGroup: self.eventLoopGroup, | |||
| logger: self.logger | |||
| ) { (request, responseWriter: consuming ResponseWriter, channel) in | |||
| let logger = self.logger.with(metadataKey: "hb_id", value: .stringConvertible(RequestID())) | |||
| let logger = self.logger.with(metadataKey: "hb.id", value: .stringConvertible(RequestID())) | |||
There was a problem hiding this comment.
Suggested change
| let logger = self.logger.with(metadataKey: "hb.id", value: .stringConvertible(RequestID())) | |
| let logger = self.logger.with(metadataKey: "http.request.id", value: .stringConvertible(RequestID())) |
There was a problem hiding this comment.
Non standard and we don't own http namespace. Using hb.request.id
|
IMO we should follow the OTel guides: |
|
So I've followed the conventions for HTTP metrics |
Joannis
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some metrics and logging name changes based off discussions in #539
These are not set in stone, but I thought implementing the changes would trigger final decisions