Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Channel configuration and HTTP1 timeout #600

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

adam-fowler
Copy link
Member

  • Add configuration struct for HTTP1 and HTTP2 channels
  • Add idle timeout parameter for HTTP1
  • Add HTTP1 config to HTTP2 config for stream channels

I intend to use the HTTP2 config to add main channel support, like idle, ping timeout, close timeout etc

Copy link

github-actions bot commented Oct 29, 2024

Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, this will allow us to add further configuration as well.
Speaking of which, we should add some detail to our additionalChannelHandlers. Do they get added before or after the HTTP handlers?

@Joannis
Copy link
Member

Joannis commented Nov 3, 2024

Let's discuss this change a bit more, I think we can improve it a bit more

@adam-fowler adam-fowler merged commit 61a7d64 into main Nov 6, 2024
6 of 7 checks passed
@adam-fowler adam-fowler deleted the channel-configuration branch November 6, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants