-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server Channel configuration and HTTP1 timeout #600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, this will allow us to add further configuration as well.
Speaking of which, we should add some detail to our additionalChannelHandlers. Do they get added before or after the HTTP handlers?
Joannis
reviewed
Nov 3, 2024
Joannis
reviewed
Nov 3, 2024
Joannis
reviewed
Nov 3, 2024
Joannis
reviewed
Nov 3, 2024
Joannis
requested changes
Nov 3, 2024
Let's discuss this change a bit more, I think we can improve it a bit more |
Joannis
reviewed
Nov 6, 2024
Co-authored-by: Joannis Orlandos <[email protected]>
Co-authored-by: Joannis Orlandos <[email protected]>
Joannis
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intend to use the HTTP2 config to add main channel support, like idle, ping timeout, close timeout etc