Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/enhance controllers config management #143

Merged
merged 36 commits into from
Jun 21, 2024

Conversation

cardosofede
Copy link
Contributor

No description provided.

@rapcmia
Copy link
Contributor

rapcmia commented Jun 18, 2024

After successfully setup with PR15, the Portfolio page returns error of streamlit.errors.StreamlitAPIException: Every Multiselect default value must exist in options which is different from want we see on cardosofede/hummingbot-deploy main version.

image

2024-06-18 12:24:28.660 Uncaught app exception
Traceback (most recent call last):
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 584, in _run_script
    exec(code, module.__dict__)
  File "/Users/rapcomia/github/dashboard/143/frontend/pages/orchestration/portfolio/app.py", line 87, in <module>
    tokens_available = st.multiselect("Select Tokens", set(tokens_available), set(tokens_available))
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/runtime/metrics_util.py", line 397, in wrapped_func
    result = non_optional_func(*args, **kwargs)
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/elements/widgets/multiselect.py", line 249, in multiselect
    return self._multiselect(
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/elements/widgets/multiselect.py", line 292, in _multiselect
    indices = _check_and_convert_to_indices(opt, default)
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/elements/widgets/multiselect.py", line 92, in _check_and_convert_to_indices
    raise StreamlitAPIException(
streamlit.errors.StreamlitAPIException: Every Multiselect default value must exist in options

@nikspz
Copy link
Contributor

nikspz commented Jun 20, 2024

@cardosofede Could you please fix branch conflicts here?

@rapcmia
Copy link
Contributor

rapcmia commented Jun 21, 2024

PR update:

After successfully setup with PR15, the Portfolio page returns error of streamlit.errors.StreamlitAPIException: Every Multiselect default value must exist in options which is different from want we see on cardosofede/hummingbot-deploy main version.

  • This behavior happened on latest version as well so not related to the PR
  • Successfully setup with PR15, hummingbot-broker and using dardonacci/hummingbot:latest
  • Create, delete and add accounts/credentials ok
  • Create, modified, add and delete controller configs ok
  • Setup pmm_simple using mexc as connector monitoring, to add updates later
  • Ran few endpoints from ..:8000/docs

Approved but PR needs fixin on branch conflicts

@cardosofede cardosofede force-pushed the feat/enhance_controllers_config_management branch from f6993ba to 7f5a58c Compare June 21, 2024 11:11
@cardosofede cardosofede merged commit be50f01 into main Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants