Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Plenty: Maintenance of Tezos and Plenty connectors #223

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Fix/Plenty: Maintenance of Tezos and Plenty connectors #223

merged 5 commits into from
Nov 13, 2023

Conversation

OjusWiZard
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using the approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Moved the CTez code from the Plenty connector to the Tezos connector, so that other dex connectors can use it.
  • Updated the default configs of both connectors for better reliability.
  • Fix some bugs in both connectors.

Tests performed by the developer:

  • Successfully ran all the tests
  • Ran the amm_arb strategy between gate and plenty with decent profitability.

@nikspz nikspz merged commit be4f240 into hummingbot:development Nov 13, 2023
3 checks passed
@rapcmia rapcmia mentioned this pull request Nov 20, 2023
Merged
2 tasks
@nikspz nikspz mentioned this pull request Nov 23, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapcmia rapcmia rapcmia approved these changes

@fengtality fengtality fengtality approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OjusWiZard @fengtality @rapcmia @nikspz