Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ QuipuSwap connector for Tezos chain #252

Merged
merged 16 commits into from
Jan 10, 2024

Conversation

OjusWiZard
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Added support for QuipuSwap Dex on the Tezos chain.

Tests performed by the developer:

  • Added unit tests for the controller and QuipuSwap main class.
  • Tested amm_arb between Binance and QuipuSwap.

Tips for QA testing:

  1. Launch the Hummingbot client as usual.
  2. Then add a non-empty Tezos wallet using it.
  3. Then create some strategy including QuipuSwap Dex connector on it.
  4. Then start the bot.

@OjusWiZard OjusWiZard marked this pull request as ready for review December 20, 2023 09:11
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Cloned and installed latest development + gwPR252
  • Created wallet at kukai.app, not able to use passphrase, not going. no private key available
  • Created wallet https://templewallet.com/ and used this private key
  • connected quipuswap_tezos_mainnet with templewallet key successfully
  • checked balance successfully
  • created amm_arb strategy using QuipuSwap_tezos_mainnet succesfully

Note: order execution not tested since testnet not available

Copy link
Contributor

@fengtality fengtality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments. Also please resolve conflicts since there was a Pancakeswap PR which was recently merged in.

src/amm/amm.controllers.ts Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@david-hummingbot
Copy link
Contributor

Hi @OjusWiZard
Would you be able to add the docs for QuipuSwap to our docs site - https://github.com/hummingbot/hummingbot-site
You can use any of the existing DEX connectors as a template.

@OjusWiZard
Copy link
Contributor Author

Hi @david-hummingbot
I've create the PR here: hummingbot/hummingbot-site#340

@david-hummingbot
Copy link
Contributor

Perfect, thanks @OjusWiZard, we'll include this in the release for 1.24. We'll be announcing the release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants