Skip to content

Commit

Permalink
Reset NACK/ACK list when parsing a new RTCP packet.
Browse files Browse the repository at this point in the history
The NACK/ACK frames/packets list need to be reset before parsing each
RTCP packet as the parser is shared by all RTCP packets on sender side.
This caused the performance regression and potentially video freezing
as well.

BUG=600527

Review URL: https://codereview.chromium.org/1853253003

Cr-Commit-Position: refs/heads/master@{#385046}
  • Loading branch information
xjz authored and Commit bot committed Apr 4, 2016
1 parent 41179c1 commit 411ea14
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions media/cast/net/rtcp/rtcp_utility.cc
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,8 @@ bool RtcpParser::ParseFeedbackCommon(base::BigEndianReader* reader,
// Please note, this frame_id is still only 8-bit!
cast_message_.ack_frame_id = last_frame_id;

cast_message_.missing_frames_and_packets.clear();
cast_message_.received_later_frames.clear();
for (size_t i = 0; i < number_of_lost_fields; i++) {
uint8_t frame_id;
uint16_t packet_id;
Expand Down

0 comments on commit 411ea14

Please sign in to comment.