Skip to content

Commit

Permalink
Fix HERMES_ENABLE_DEBUGGER define for jsinspector-modern under CocoaPods
Browse files Browse the repository at this point in the history
Summary:
> [!Note]
> Replaces facebook#46282.

We intended to enable Fusebox on `main` since facebook#45469 — this worked when building under Buck, however was not working for builds under Xcode. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag was missing for the `React-jsinspector` Podspec.

Differential Revision: D62375148
  • Loading branch information
huntie authored and facebook-github-bot committed Sep 9, 2024
1 parent 3621606 commit 61ed666
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/react-native/scripts/cocoapods/utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def self.has_pod(installer, name)

def self.set_gcc_preprocessor_definition_for_React_hermes(installer)
self.add_build_settings_to_pod(installer, "GCC_PREPROCESSOR_DEFINITIONS", "HERMES_ENABLE_DEBUGGER=1", "React-hermes", "Debug")
self.add_build_settings_to_pod(installer, "GCC_PREPROCESSOR_DEFINITIONS", "HERMES_ENABLE_DEBUGGER=1", "React-jsinspector", "Debug")
self.add_build_settings_to_pod(installer, "GCC_PREPROCESSOR_DEFINITIONS", "HERMES_ENABLE_DEBUGGER=1", "hermes-engine", "Debug")
self.add_build_settings_to_pod(installer, "GCC_PREPROCESSOR_DEFINITIONS", "HERMES_ENABLE_DEBUGGER=1", "React-RuntimeHermes", "Debug")
end
Expand Down

0 comments on commit 61ed666

Please sign in to comment.