-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unintended UI flipping in right-to-left languages #429
Comments
In the right-to-left language, are the window control buttons (minimize, maximize, close) on the left or the right of the window? There shouldn't be any navigation issue right? I did not expect WebView and SwapChainPanel to get flipped by RTL as well... Fortunately, the solution is straightforward. I can force certain elements to not flip. Just as I can apply RTL even in English. |
Forcing WebView and VideoView to always flow LTR. ApplicationFrameHost_Oiq4BbUb2X.mp4@Y-PLONI Are there more UI elements or layouts that you think look off in Hebrew? Do the sliders and buttons behave correctly, and are they in the expected spots? |
Actually, that's what I did in the ManifestResources.resw file... |
I didn't understand what you meant. Can you explain more? |
Forgive my limited knowledge on this area, but I recall that some icons need to be flipped (e.g. the volume glyph, etc.) and after reviewing some documentation it seems to confirm that (except for those indicating directionality and right handedness). |
@huynhsontung Looks great! |
@huynhsontung Is there a release with the fix, or not? |
@Y-PLONI Yes, there will be a new release. Store publishing takes from a few hours to a few days. It's going to be available for download in the preview channel first, then in the main public channel later. I will also fix the store listing when it goes into the public channel. |
How do you subscribe to the preview channel? |
@Y-PLONI I must add your Store account on my end using your Store email. You can send me an email at [email protected] |
I suggest you put in the settings "subscribe to the preview channel". It could be MAILTO. |
@huynhsontung |
@huynhsontung |
By the way, I couldn't find where to translate the titles media, music, file |
@Y-PLONI You are right, the header texts for Media, Music, File are not properly localized. It will be fixed in the next patch. I also just noticed that the title bar offset issue affects the app title and the player title bar, which is quite serious. In LTR, that space is reserved for the window controls. I'm surprised that it doesn't get flipped properly, considering if I force-enable RTL in English, the issue does not appear. |
@huynhsontung |
@Y-PLONI The above PR should fix the title bar padding issue and properties dialog RTL issue. |
@huynhsontung |
@Y-PLONI These errors are emitted from VLC and shown as-is. We don't map them to a localized string so translation is impossible. |
@huynhsontung It's a good call but there's an alternative solution: adding a human readable translatable explanation to the original error message, this way the user can still search for the original message and find solutions on the internet while understanding the error in its own language. |
@huynhsontung |
The image is displayed upside down, here is a screenshot in Windows Media Player
And here is a picture from Screenbox
As I wrote here:
#418 (comment)
The problems are that the application is configured in Windows in Hebrew mode and the operating system creates RTL for everything possible, including what is not needed...
In my opinion, if possible, you should set the application as English, and only the text in it will be in Hebrew.
If not possible, write to me and I will try to investigate the issue!
I use Windows 11, the latest version of the app released in the store.
The text was updated successfully, but these errors were encountered: