Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New kv classes #257

Merged
merged 7 commits into from
Aug 31, 2018
Merged

New kv classes #257

merged 7 commits into from
Aug 31, 2018

Conversation

jeffwecan
Copy link
Member

Starting to add in some kv-related classes in preparation for more robust kv version 2 support.

I am especially keen to get your feedback on the pattern being set up in the Kv class (meant to be a wrapper to make it easier to default to one kv secret engine version or another across the board) @dbwpe.

@codecov-io
Copy link

codecov-io commented Aug 31, 2018

Codecov Report

Merging #257 into master will increase coverage by 0.67%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   88.49%   89.16%   +0.67%     
==========================================
  Files          12       15       +3     
  Lines        1017     1080      +63     
==========================================
+ Hits          900      963      +63     
  Misses        117      117
Impacted Files Coverage Δ
hvac/api/__init__.py 100% <100%> (ø) ⬆️
hvac/v1/__init__.py 85.55% <100%> (+0.06%) ⬆️
hvac/api/secrets_engines/__init__.py 100% <100%> (ø)
hvac/api/secrets_engines/kv.py 100% <100%> (ø)
hvac/api/secrets_engines/kv_v1.py 100% <100%> (ø)

@jeffwecan jeffwecan merged commit 5f92583 into hvac:master Aug 31, 2018
@jeffwecan jeffwecan deleted the new_kv_classes branch August 31, 2018 21:14
@jeffwecan jeffwecan mentioned this pull request Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants