Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] identity secrets engine #269

Merged
merged 20 commits into from
Oct 31, 2018

Conversation

tiny-dancer
Copy link
Contributor

@tiny-dancer tiny-dancer commented Sep 19, 2018

opening for visibility, still a WIP and verifying.

https://www.vaultproject.io/api/secret/identity/index.html

TODO:

  • Entity
  • Entity Alias
  • Lookup
  • documentation
  • tests

Out of Scope:

  • Group
  • Group Alias

@jeffwecan
Copy link
Member

I know this is still a work-in-progress, but just wanted to call out that it would be nice to get some usage information for http://hvac.readthedocs.io/ as outlined in https://github.com/hvac/hvac/blob/master/CONTRIBUTING.md#examples whenever you get to that point. 👍

@jeffwecan
Copy link
Member

Oh and do you think you'll have time to wrap up the changes in this PR over the next week or so? (If so, I'll tag it for the 0.6.5 milestone.)

@jeffwecan jeffwecan added the enhancement a new feature or addition label Sep 19, 2018
@tiny-dancer
Copy link
Contributor Author

over the next week or so

yup that should work!

@codecov-io
Copy link

codecov-io commented Sep 19, 2018

Codecov Report

Merging #269 into master will increase coverage by 0.01%.
The diff coverage is 90.73%.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   90.64%   90.65%   +0.01%     
==========================================
  Files          39       41       +2     
  Lines        1893     2152     +259     
==========================================
+ Hits         1716     1951     +235     
- Misses        177      201      +24
Impacted Files Coverage Δ
hvac/api/secrets_engines/__init__.py 100% <100%> (ø) ⬆️
hvac/constants/identity.py 100% <100%> (ø)
hvac/api/secrets_engines/identity.py 90.62% <90.62%> (ø)

@jeffwecan jeffwecan added secrets engines generally related to a Vault secrets engine identity Identity secrets engine; identity management solution for Vault labels Sep 30, 2018
@jeffwecan jeffwecan added this to the 0.6.6 milestone Oct 3, 2018
@jeffwecan jeffwecan removed the enhancement a new feature or addition label Oct 3, 2018
@jeffwecan
Copy link
Member

@tiny-dancer: Fair warning, I'm planning on wrapping up the changes you have started here and will push those updates to your branch over the next couple days. 😀

@tiny-dancer
Copy link
Contributor Author

Awesome! Thanks for picking up the slack 🙏

@jeffwecan jeffwecan modified the milestones: 0.7.1, 0.7.0 Oct 31, 2018
@jeffwecan jeffwecan force-pushed the feature/identity-secrets-engine branch from 4d3212c to 39bba98 Compare October 31, 2018 16:57
@jeffwecan jeffwecan merged commit 1d82242 into hvac:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
identity Identity secrets engine; identity management solution for Vault secrets engines generally related to a Vault secrets engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants