Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.10.0 #560

Merged
merged 8 commits into from
Feb 27, 2020
Merged

Release v0.10.0 #560

merged 8 commits into from
Feb 27, 2020

Conversation

jeffwecan
Copy link
Member

No description provided.

Adrian Eib and others added 8 commits February 26, 2020 22:48
for those of us who are reckless copy-pasters
* Only send optional parameters when supplied

This modifies functions to only send optional parameters when a value has explicitly been supplied.
Doing so prevents "update" functions from clobbering preexisting values when they're not supplied.
Additionally, all default parameter values have been changed to to None so that the Vault server can select the appropriate default value.

* Fix and extend Azure test case

Co-authored-by: Jeffrey Hogan <[email protected]>
@jeffwecan jeffwecan requested a review from a team as a code owner February 27, 2020 04:50
@codecov-io
Copy link

codecov-io commented Feb 27, 2020

Codecov Report

Merging #560 into master will increase coverage by 0.89%.
The diff coverage is 81.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   82.13%   83.03%   +0.89%     
==========================================
  Files          56       55       -1     
  Lines        3029     2976      -53     
==========================================
- Hits         2488     2471      -17     
+ Misses        541      505      -36
Impacted Files Coverage Δ
hvac/api/auth_methods/ldap.py 100% <100%> (ø) ⬆️
hvac/api/system_backend/audit.py 95.45% <100%> (+0.21%) ⬆️
hvac/utils.py 75.7% <100%> (-1.45%) ⬇️
hvac/api/auth_methods/okta.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/pki.py 100% <100%> (ø) ⬆️
hvac/api/secrets_engines/aws.py 98.18% <100%> (+0.1%) ⬆️
hvac/api/secrets_engines/gcp.py 46.15% <100%> (+0.84%) ⬆️
hvac/api/auth_methods/github.py 100% <100%> (ø) ⬆️
hvac/api/system_backend/auth.py 87.5% <100%> (+0.32%) ⬆️
hvac/constants/transit.py 100% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c32776...7911a01. Read the comment docs.

@jeffwecan jeffwecan merged commit 62ba8f0 into master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants