Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding readBySend #40

Merged
merged 5 commits into from
Oct 20, 2024
Merged

adding readBySend #40

merged 5 commits into from
Oct 20, 2024

Conversation

tyou0
Copy link

@tyou0 tyou0 commented Oct 11, 2024

Description

Addin readBySend

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tyou0
Copy link
Author

tyou0 commented Oct 11, 2024

Copy link
Owner

@hwonyo hwonyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다.
테스트 코드까지 추가해주시면 approve 하겠습니다.

nta/api.py Outdated Show resolved Hide resolved
nta/api.py Outdated Show resolved Hide resolved
nta/models/payload.py Outdated Show resolved Hide resolved
nta/models/payload.py Outdated Show resolved Hide resolved
@tyou-docenty
Copy link

formatting tool 어떤거 쓰시나요?

string 이 어떤건 " 어떤건 ' 를 쓰는데 autoformatting tool 사용하는게 좋을것 같아요.

VScode 에서 md plugin 사용 하면 readme에서 table contents to update 해주는데 table contents가 out of date이라고 나오네요.
markdown-all-in-one

@hwonyo hwonyo self-requested a review October 20, 2024 10:59
Copy link
Owner

@hwonyo hwonyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README 작성까지 감사합니다. 덕분에 오랜만에 업데이트 했네요

@hwonyo
Copy link
Owner

hwonyo commented Oct 20, 2024

formatting tool 어떤거 쓰시나요?
string 이 어떤건 " 어떤건 ' 를 쓰는데 autoformatting tool 사용하는게 좋을것 같아요.

formatting tool 적용 안 했습니다. 의견 듣고 black으로 적용할까합니다.

VScode 에서 md plugin 사용 하면 readme에서 table contents to update 해주는데 table contents가 out of date이라고 나오네요. markdown-all-in-one

감사합니다. md도 확인하고 업데이트하겠습니다.

@hwonyo hwonyo merged commit dbf28d6 into hwonyo:master Oct 20, 2024
@hwonyo
Copy link
Owner

hwonyo commented Oct 20, 2024

commit 계정이 뭔가 꼬였네요 ㅠ
혹시 추가 의견 주신 부분도 작성해주신다면 기다리겠습니다

@tyou0
Copy link
Author

tyou0 commented Oct 21, 2024

아 워낙에 잘쓰셔서 저도 편하게 잘 만들었어요
혹시 오픈 소스나 다른 프로젝트 있으면 함 같이 만들어요 좀 배우고 싶네요

@tyou0
Copy link
Author

tyou0 commented Oct 23, 2024

@hwonyo 아 버전업해서 pip에 올려주세요

@tyou0 tyou0 deleted the add-readBySend branch October 23, 2024 04:40
@hwonyo
Copy link
Owner

hwonyo commented Oct 24, 2024

@tyou0 1.0.6으로 버전업했습니다

아 워낙에 잘쓰셔서 저도 편하게 잘 만들었어요 혹시 오픈 소스나 다른 프로젝트 있으면 함 같이 만들어요 좀 배우고 싶네요

좋습니다 ㅎㅎ 요즘 개인적으로 진행하는건 없어서 뭔가 생기면 같이 해보시죠.
링크드인 하시면 연락주세요. linkedin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants