Skip to content

Commit

Permalink
Remove unused always true check
Browse files Browse the repository at this point in the history
This does not work, and is not worth fixing as the setup kernel time amounts to 0.002ms per run, which is 2ms for the entire unit test suite of just over 1000 tests, and only a subset of those even use this.
  • Loading branch information
caendesilva committed Sep 8, 2024
1 parent e02bc9d commit 6f57ffe
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions packages/testing/src/UnitTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,13 @@

abstract class UnitTestCase extends BaseTestCase
{
protected static bool $hasSetUpKernel = false;

protected static bool $needsKernel = false;
protected static bool $needsConfig = false;
protected static bool $needsRender = false;

protected static function needsKernel(): void
{
if (! self::$hasSetUpKernel) {
self::setupKernel();
}
self::setupKernel();
}

public static function setUpBeforeClass(): void
Expand All @@ -44,7 +40,6 @@ public static function setUpBeforeClass(): void
protected static function setupKernel(): void
{
HydeKernel::setInstance(new HydeKernel());
self::$hasSetUpKernel = true;
}

protected static function resetKernel(): void
Expand Down

0 comments on commit 6f57ffe

Please sign in to comment.