Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove the BaseUrlNotSetException class #1758

Closed
2 tasks done
caendesilva opened this issue Jun 29, 2024 · 1 comment
Closed
2 tasks done

Deprecate and remove the BaseUrlNotSetException class #1758

caendesilva opened this issue Jun 29, 2024 · 1 comment

Comments

@caendesilva
Copy link
Member

caendesilva commented Jun 29, 2024

The BaseUrlNotSetException class is no longer necessary as we now handle many of the cases where we previously used this exception more gracefully. Currently, the exception is only used in the Hyde::url() helper, which could return null instead. A custom exception for just this case is no longer warranted.

To implement this change, we need two pull requests:

  1. On the 1.x branch, we deprecate the BaseUrlNotSetException class and document the new returning behaviour.
  2. On the 2.x branch, we remove the deprecated BaseUrlNotSetException class and update the Hyde::url() helper to return null instead of throwing the exception.

Tasks

@caendesilva
Copy link
Member Author

Fixed by #1759 and #1760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant