You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The BaseUrlNotSetException class is no longer necessary as we now handle many of the cases where we previously used this exception more gracefully. Currently, the exception is only used in the Hyde::url() helper, which could return null instead. A custom exception for just this case is no longer warranted.
To implement this change, we need two pull requests:
On the 1.x branch, we deprecate the BaseUrlNotSetException class and document the new returning behaviour.
On the 2.x branch, we remove the deprecated BaseUrlNotSetException class and update the Hyde::url() helper to return null instead of throwing the exception.
The content you are editing has changed. Please copy your edits and refresh the page.
The
BaseUrlNotSetException
class is no longer necessary as we now handle many of the cases where we previously used this exception more gracefully. Currently, the exception is only used in theHyde::url()
helper, which could returnnull
instead. A custom exception for just this case is no longer warranted.To implement this change, we need two pull requests:
BaseUrlNotSetException
class and document the new returning behaviour.BaseUrlNotSetException
class and update theHyde::url()
helper to returnnull
instead of throwing the exception.Tasks
BaseUrlNotSetException
class #1759BaseUrlNotSetException
class #1760The text was updated successfully, but these errors were encountered: