[2.x] Change default DocumentationPage group to be null instead of 'other'
#1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
added
the
run-visual-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1572 +/- ##
=================================================================
Coverage 100.00% 100.00%
+ Complexity 1761 1760 -1
=================================================================
Files 184 184
Lines 4765 4765
=================================================================
Hits 4765 4765 ☔ View full report in Codecov by Sentry. |
…mentation-page-group-to-be-null-instead-of-other
caendesilva
deleted the
change-default-documentation-page-group-to-be-null-instead-of-other
branch
caendesilva
removed
the
run-visual-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's kinda weird that we've been using
'other'as a sort of pseudo-null state. It only makes sense for the group to be other when there are other groups, so that should be handled in the frontend Blade, thus we instead now null coalesce to'Other'when creating the group title.This is breaking and targets V2 (specifically #1568)