Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Clean up navigation view markup #1606

Merged
merged 57 commits into from
Mar 18, 2024
Merged

[2.x] Clean up navigation view markup #1606

merged 57 commits into from
Mar 18, 2024

Commits on Mar 13, 2024

  1. Include navigation link as Blade component instead of include 

    Looks more consistent with the dropdown include just above, and we can use attributes
    @caendesilva
    caendesilva committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    894a865 View commit details
    Browse the repository at this point in the history

  2. Fix component name

    @caendesilva
    caendesilva committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    52f2d0c View commit details
    Browse the repository at this point in the history

  3. Add CSS class hooks for the navigation link states 

    Adds a styling hook, and makes it more readable and testable
    @caendesilva
    caendesilva committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6ba9eaf View commit details
    Browse the repository at this point in the history

  4. Include dropdown navigation item as Blade component 

    Normalizes with 894a865
    @caendesilva
    caendesilva committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c61eef9 View commit details
    Browse the repository at this point in the history

  5. Refactor component to use attribute merging 

    Create attribute bag in test setup
Update test to expect cleaner HTML output
    @caendesilva
    caendesilva committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    759c63a View commit details
    Browse the repository at this point in the history

  6. Test inverse attribute state

    @caendesilva
    caendesilva committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5710b1a View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary parentheses

    @caendesilva
    caendesilva committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5ffeac4 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ac2e0ba View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Add testing helper to make NavItem for page

    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6a47409 View commit details
    Browse the repository at this point in the history

  2. Add improved assertion output

    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2cd3da2 View commit details
    Browse the repository at this point in the history

  3. Test component resolves relative links for routes

    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d5f33f6 View commit details
    Browse the repository at this point in the history

  4. Simplify test data handling

    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a4c0f9e View commit details
    Browse the repository at this point in the history

  5. Add more attribute assertion helpers

    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c042cf7 View commit details
    Browse the repository at this point in the history

  6. Refactor test to use fluent assertions

    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b7fb433 View commit details
    Browse the repository at this point in the history

  7. Add testing helper to dump and die with HTML state

    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7b1868e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c3d756e View commit details
    Browse the repository at this point in the history

  9. Refactor test to use fluent assertions

    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    282d1fe View commit details
    Browse the repository at this point in the history

  10. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e15daca View commit details
    Browse the repository at this point in the history

  11. Use helper method fluently

    @caendesilva
    caendesilva committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    add2390 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Update testing helper to automatically parse attributes 

    Adds an option to use this with just the full attribute string
    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    68d46ff View commit details
    Browse the repository at this point in the history

  2. Use shorthand attribute testing syntax

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cd1e567 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b4bb5f4 View commit details
    Browse the repository at this point in the history

  4. Add assertion

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2a1c9cc View commit details
    Browse the repository at this point in the history

  5. Remove duplicated test case

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    322862b View commit details
    Browse the repository at this point in the history

  6. Refactor tests to use fluent assertions

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cc071eb View commit details
    Browse the repository at this point in the history

  7. Remove unused testing helper

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c66c5c8 View commit details
    Browse the repository at this point in the history

  8. Remove unused parameter from testing helper method

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b451eff View commit details
    Browse the repository at this point in the history

  9. Add testing helpers to assert CSS class states

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fbb5bfd View commit details
    Browse the repository at this point in the history

  10. Use new class state helpers

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d5411eb View commit details
    Browse the repository at this point in the history

  11. Clean up and normalize test semantics

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fd1c68a View commit details
    Browse the repository at this point in the history

  12. Add testing helper to assert element state

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b0d4331 View commit details
    Browse the repository at this point in the history

  13. Test component renders

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8449237 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7bce5eb View commit details
    Browse the repository at this point in the history

  15. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ed1ae9c View commit details
    Browse the repository at this point in the history

  16. Create SidebarItemsViewTest.php

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2439b72 View commit details
    Browse the repository at this point in the history

  17. Add testing helper to assert if an HTML ID is present

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4f7dd3b View commit details
    Browse the repository at this point in the history

  18. Update testing helper to fluently direct assertions

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    1d5e1f7 View commit details
    Browse the repository at this point in the history

  19. Set up testing helper

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4fa8dea View commit details
    Browse the repository at this point in the history

  20. Test component renders

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2d9ae2a View commit details
    Browse the repository at this point in the history

  21. Mock route

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3ebd20f View commit details
    Browse the repository at this point in the history

  22. Add a route to populate testing sidebar

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2eeed5f View commit details
    Browse the repository at this point in the history

  23. Add type annotation to view

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a0c0726 View commit details
    Browse the repository at this point in the history

  24. Add more mock pages to test

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    12dfbc4 View commit details
    Browse the repository at this point in the history

  25. Move mock route call to setup

    @caendesilva
    caendesilva committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    361325f View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Test high level active states 

    Granular logic belongs in child tests
    @caendesilva
    caendesilva committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    5d45940 View commit details
    Browse the repository at this point in the history

  2. Assert see list item class

    @caendesilva
    caendesilva committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    627a3f2 View commit details
    Browse the repository at this point in the history

  3. Add testing helper to assert string occurrence count

    @caendesilva
    caendesilva committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    668961a View commit details
    Browse the repository at this point in the history

  4. Assert see times

    @caendesilva
    caendesilva committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    f04a46f View commit details
    Browse the repository at this point in the history

  5. Use clearer assertion string

    @caendesilva
    caendesilva committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    ce51a65 View commit details
    Browse the repository at this point in the history

  6. Add fluent assertion shorthand method

    @caendesilva
    caendesilva committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    7a3ca45 View commit details
    Browse the repository at this point in the history

  7. Remove redundant argument

    @caendesilva
    caendesilva committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    be2bc01 View commit details
    Browse the repository at this point in the history

  8. Assert see once

    @caendesilva
    caendesilva committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    9c27a98 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    5061326 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    18c3442 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge branch '2.x-dev' into improved-navigation-internals

    @caendesilva
    caendesilva committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    fc3a63c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f6257f9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'improved-navigation-internals' into clean-up-navigation… 

    …-view-markup
    @caendesilva
    caendesilva committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b84cdf2 View commit details
    Browse the repository at this point in the history