[2.x] Create better fallbacks when not supplying a navigation item label #1638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #1568
Since null is not allowed, we needed to coalesce to an empty string. This makes no sense from a practical usability perspective: What's the point of a link in the menu that you can't click because there is no label to click? It makes more sense to fall back to the link to make it usable, and give a nudge to the developer that they may want to change it into something more visually pleasing.