Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Remove the group property from the navigation item class #1639

Conversation

caendesilva
Copy link
Member

Targets #1568.

Do we actually need this? We should just care if it's physically stored in a group. Adding the group key here doesn't magically make it appear in the group, it needs to be added to the group's items array, so why should we care about the key here?

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (c33a6ec) to head (de6993b).

Additional details and impacted files
@@                         Coverage Diff                         @@
##             improved-navigation-internals    #1639      +/-   ##
===================================================================
- Coverage                            99.93%   99.93%   -0.01%     
+ Complexity                            1779     1778       -1     
===================================================================
  Files                                  184      184              
  Lines                                 4802     4799       -3     
===================================================================
- Hits                                  4799     4796       -3     
  Misses                                   3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the remove-the-group-property-from-navigation-item-class branch from 26782e9 to 0eda65f Compare March 24, 2024 17:27
@caendesilva caendesilva force-pushed the remove-the-group-property-from-navigation-item-class branch from ca6d3b5 to 6b67552 Compare March 24, 2024 18:10
@caendesilva caendesilva marked this pull request as ready for review March 24, 2024 21:27
@caendesilva caendesilva merged commit 16ded04 into improved-navigation-internals Mar 24, 2024
8 checks passed
@caendesilva caendesilva deleted the remove-the-group-property-from-navigation-item-class branch March 24, 2024 21:28
@caendesilva caendesilva mentioned this pull request Jun 27, 2024
74 tasks
@caendesilva caendesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant