-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Refactor filesystem helpers #1698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3ec072a.
caendesilva
force-pushed
the
refactor-filesystem-helpers
branch
from
April 29, 2024 12:21
31bdc91
to
2872b8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1698 +/- ##
=============================================
- Coverage 99.97% 99.97% -0.01%
+ Complexity 1773 1769 -4
=============================================
Files 183 183
Lines 4714 4706 -8
=============================================
- Hits 4713 4705 -8
Misses 1 1 ☔ View full report in Codecov by Sentry. |
caendesilva
added a commit
that referenced
this pull request
Apr 29, 2024
[2.x] Refactor filesystem helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes here can now be cherry picked to master as none of these are breaking, as only the implementations are refactored, but none of the APIs.