Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Support automatic navigation priorities by prefixing a number in filenames #1709

Merged
merged 100 commits into from
May 4, 2024
Merged

[2.x] Support automatic navigation priorities by prefixing a number in filenames #1709

merged 100 commits into from
May 4, 2024

Commits on Apr 30, 2024

  1. Create FilenamePrefixNavigationPriorityTest.php

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7e5a1c9 View commit details
    Browse the repository at this point in the history

  2. Spec out the test

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4950f8b View commit details
    Browse the repository at this point in the history

  3. Draft fixture helpers

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    37e74f9 View commit details
    Browse the repository at this point in the history

  4. Define fixture data

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7f733e0 View commit details
    Browse the repository at this point in the history

  5. Add more fixtures

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d4b3829 View commit details
    Browse the repository at this point in the history

  6. Draft new tests

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1fa4ab2 View commit details
    Browse the repository at this point in the history

  7. Create FilenamePrefixNavigationHelper.php

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b2ca812 View commit details
    Browse the repository at this point in the history

  8. Add helper to check if identifier is numbered

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7484d56 View commit details
    Browse the repository at this point in the history

  9. Create a temporary way to declare tests within the class 

    Allows Copilot to better generate tests, we will move these back to the test later
    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d05ee52 View commit details
    Browse the repository at this point in the history

  10. Add coverage annotation

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3fc5752 View commit details
    Browse the repository at this point in the history

  11. Skip unimplemented tests

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b87eee1 View commit details
    Browse the repository at this point in the history

  12. Add enabled helper

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8d167ba View commit details
    Browse the repository at this point in the history

  13. Document methods

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3aa4247 View commit details
    Browse the repository at this point in the history

  14. Split number and identifier

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1782555 View commit details
    Browse the repository at this point in the history

  15. Introduce local variable

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    66fe07c View commit details
    Browse the repository at this point in the history

  16. Parse the number to an integer

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a0c20ea View commit details
    Browse the repository at this point in the history

  17. Assert type structure

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    df35e5a View commit details
    Browse the repository at this point in the history

  18. Annotate method

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ae17392 View commit details
    Browse the repository at this point in the history

  19. Refactor inline test hack to load full class

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7a9fd63 View commit details
    Browse the repository at this point in the history

  20. Import used functions

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9795e0d View commit details
    Browse the repository at this point in the history

  21. Check the config for enabled state

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9c5fa98 View commit details
    Browse the repository at this point in the history

  22. Rename tests for new design plan 

    See #1709 (comment) (edit 2 and 3)
    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    bfa6642 View commit details
    Browse the repository at this point in the history

  23. Implement the tests

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c05e72e View commit details
    Browse the repository at this point in the history

  24. Update route key creation to split numbered identifiers

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9271e40 View commit details
    Browse the repository at this point in the history

  25. Extract experimental helper method

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    777ac9d View commit details
    Browse the repository at this point in the history

  26. Move down helper method

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    09a828e View commit details
    Browse the repository at this point in the history

  27. Merge inline test into test case

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8b7ce81 View commit details
    Browse the repository at this point in the history

  28. Revert "Merge inline test into test case" 

    This reverts commit 8b7ce81.
    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c5e0433 View commit details
    Browse the repository at this point in the history

  29. Change mock syntax

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2936b34 View commit details
    Browse the repository at this point in the history

  30. Skip assertion test

    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fe2c157 View commit details
    Browse the repository at this point in the history

  31. Reapply "Merge inline test into test case" 

    This reverts commit c5e0433.
    @caendesilva
    caendesilva committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    14757ab View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Revert "Reapply "Merge inline test into test case"" 

    This reverts commit 14757ab.
    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e947a62 View commit details
    Browse the repository at this point in the history

  2. Extract proper test file

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0792b86 View commit details
    Browse the repository at this point in the history

  3. Disable page ordering in unrelated test

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    59a8a81 View commit details
    Browse the repository at this point in the history

  4. Set up coverage

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9c1507d View commit details
    Browse the repository at this point in the history

  5. Create initial fixture setup helper 

    Takes about 7ms for 3 pages so really needs to be optimized to use the VFS
    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e936b9c View commit details
    Browse the repository at this point in the history

  6. Add pages to kernel directly without the filesystem 

    Much faster to do it this way
    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e248e67 View commit details
    Browse the repository at this point in the history

  7. Generate some content for the page

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4140df1 View commit details
    Browse the repository at this point in the history

  8. Draft first test

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bfd8cac View commit details
    Browse the repository at this point in the history

  9. Add the page to kernel routes

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4b59760 View commit details
    Browse the repository at this point in the history

  10. Run without default pages

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b59f73e View commit details
    Browse the repository at this point in the history

  11. Add todo

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    61c484e View commit details
    Browse the repository at this point in the history

  12. Set up clean environment in setup

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9b01811 View commit details
    Browse the repository at this point in the history

  13. Add helper to assert order

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3047f96 View commit details
    Browse the repository at this point in the history

  14. Assert order

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f7303d8 View commit details
    Browse the repository at this point in the history

  15. Remove unused parameter

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3184159 View commit details
    Browse the repository at this point in the history

  16. Fix formatting

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7a8f478 View commit details
    Browse the repository at this point in the history

  17. Remove unused variable

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0102377 View commit details
    Browse the repository at this point in the history

  18. Test the reverse order

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9ae4ebd View commit details
    Browse the repository at this point in the history

  19. Return this instead of array

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f9290c0 View commit details
    Browse the repository at this point in the history

  20. Add todo

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b08bc08 View commit details
    Browse the repository at this point in the history

  21. Draft new helper to check file prefix for priority

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b61d821 View commit details
    Browse the repository at this point in the history

  22. Early return to null when not enabled

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a2fce92 View commit details
    Browse the repository at this point in the history

  23. Early return to null when not numbered

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    78c486f View commit details
    Browse the repository at this point in the history

  24. Return the parsed number

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9853fce View commit details
    Browse the repository at this point in the history

  25. Set dropdown config setting for test

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5b3a7dd View commit details
    Browse the repository at this point in the history

  26. Create subpages when setting up the fixture

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4c1d886 View commit details
    Browse the repository at this point in the history

  27. Convert the arrow function to a traditional closure

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    12d5b74 View commit details
    Browse the repository at this point in the history

  28. Handle groups when creating comparison structure

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9c3fd64 View commit details
    Browse the repository at this point in the history

  29. Add helper to check if identifier is nested

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c5aaa2f View commit details
    Browse the repository at this point in the history

  30. Add helper to get core part of identifier

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    21e2dc7 View commit details
    Browse the repository at this point in the history

  31. Add helper to get nested identifier prefix

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2934630 View commit details
    Browse the repository at this point in the history

  32. Test parsing for nested identifiers

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ef05a52 View commit details
    Browse the repository at this point in the history

  33. Test parsing for deeply nested identifiers

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    abadc4f View commit details
    Browse the repository at this point in the history

  34. Get core identifier part when nested

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a0d8de5 View commit details
    Browse the repository at this point in the history

  35. If identifier is nested then split out its parts

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    daf674c View commit details
    Browse the repository at this point in the history

  36. Reassemble identifier when split

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    414c328 View commit details
    Browse the repository at this point in the history

  37. Properly support nested identifiers

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    468caac View commit details
    Browse the repository at this point in the history

  38. Swap method order for more logical class structure

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    888902c View commit details
    Browse the repository at this point in the history

  39. Add crosslink annotations between related tests

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9bcb09f View commit details
    Browse the repository at this point in the history

  40. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8a1bfe9 View commit details
    Browse the repository at this point in the history

  41. Map with keys

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8e92996 View commit details
    Browse the repository at this point in the history

  42. Convert the arrow function to a traditional closure

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f25f53b View commit details
    Browse the repository at this point in the history

  43. Get only core part for comparison

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a326e02 View commit details
    Browse the repository at this point in the history

  44. Use basename function

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c5ab6b8 View commit details
    Browse the repository at this point in the history

  45. Add closure types

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8c64294 View commit details
    Browse the repository at this point in the history

  46. Add a newline

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3d09881 View commit details
    Browse the repository at this point in the history

  47. Test grouped menu ordering

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    43bc495 View commit details
    Browse the repository at this point in the history

  48. Fix testing helper visibility

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ead9d95 View commit details
    Browse the repository at this point in the history

  49. Add recursive array reverser

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    543cd9f View commit details
    Browse the repository at this point in the history

  50. Test reverse ordering for grouped fixture

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    16a8c6a View commit details
    Browse the repository at this point in the history

  51. Generate base sidebar tests

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c2e4745 View commit details
    Browse the repository at this point in the history

  52. Create scaffolding to test sidebar orders

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b548bf3 View commit details
    Browse the repository at this point in the history

  53. Fix duplicated fixture data 

    Not allowed when using flattened output paths
    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1f5fb15 View commit details
    Browse the repository at this point in the history

  54. Expect other pages to be in other group

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    306b336 View commit details
    Browse the repository at this point in the history

  55. Reformat array

    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2f82b49 View commit details
    Browse the repository at this point in the history

  56. Update documentation page route key formatting to use normalized parent 

    This should generally have the same semantics, however, it allows us to use the numbering prefix normalization provided by #1709
    @caendesilva
    caendesilva committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8c181f2 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Extract testing helper class for complex testing helper methods

    @caendesilva
    caendesilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    87af9b7 View commit details
    Browse the repository at this point in the history

  2. Refactor and clean up testing helpers

    @caendesilva
    caendesilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4010632 View commit details
    Browse the repository at this point in the history

  3. Refactor testing helpers

    @caendesilva
    caendesilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f00a66e View commit details
    Browse the repository at this point in the history

  4. Use extension agnostic basename

    @caendesilva
    caendesilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f94bd4c View commit details
    Browse the repository at this point in the history

  5. Add additional fixture tests

    @caendesilva
    caendesilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c350311 View commit details
    Browse the repository at this point in the history

  6. Inline fixtures to make tests clearer

    @caendesilva
    caendesilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6d97995 View commit details
    Browse the repository at this point in the history

  7. Rename test methods using ChatGPT to make them clearer

    @caendesilva
    caendesilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2a7b359 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Document numerical prefix navigation ordering

    @caendesilva
    caendesilva committed May 3, 2024
    Configuration menu
    Copy the full SHA
    333b139 View commit details
    Browse the repository at this point in the history

  2. Improve documentation formatting

    @caendesilva
    caendesilva committed May 3, 2024
    Configuration menu
    Copy the full SHA
    755cbfc View commit details
    Browse the repository at this point in the history

  3. Document using numerical prefix ordering in subdirectories

    @caendesilva
    caendesilva committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3787c60 View commit details
    Browse the repository at this point in the history

  4. Fix formatting

    @caendesilva
    caendesilva committed May 3, 2024
    Configuration menu
    Copy the full SHA
    eac372f View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Rename added config option to match documented value

    @caendesilva
    caendesilva committed May 4, 2024
    Configuration menu
    Copy the full SHA
    d73e9c4 View commit details
    Browse the repository at this point in the history

  2. Update RELEASE_NOTES.md

    @caendesilva
    caendesilva committed May 4, 2024
    Configuration menu
    Copy the full SHA
    8a28111 View commit details
    Browse the repository at this point in the history