Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Includes facade improvements #1738

Merged
merged 105 commits into from
Jun 26, 2024
Merged

[2.x] Includes facade improvements #1738

merged 105 commits into from
Jun 26, 2024

Commits on Jun 26, 2024

  1. Extract helper method

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    25733a1 View commit details
    Browse the repository at this point in the history

  2. Get file contents using filesystem facade

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2da4e75 View commit details
    Browse the repository at this point in the history

  3. Get file existence using filesystem facade

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2df07d5 View commit details
    Browse the repository at this point in the history

  4. Create IncludesFacadeUnitTest.php

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3a73736 View commit details
    Browse the repository at this point in the history

  5. Add test crosslinks

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    dfc5581 View commit details
    Browse the repository at this point in the history

  6. Generate unit test with GPT 4

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    48180bc View commit details
    Browse the repository at this point in the history

  7. Test needs kernel

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8a776ef View commit details
    Browse the repository at this point in the history

  8. Clean up formatting

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b117a37 View commit details
    Browse the repository at this point in the history

  9. Use mockable get instead of get contents

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d66537d View commit details
    Browse the repository at this point in the history

  10. Revert "Use mockable get instead of get contents" 

    This reverts commit d66537d.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    85314bf View commit details
    Browse the repository at this point in the history

  11. Reapply "Use mockable get instead of get contents" 

    This reverts commit 85314bf.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    37e7ddd View commit details
    Browse the repository at this point in the history

  12. Use Illuminate filesystem

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    84a6d93 View commit details
    Browse the repository at this point in the history

  13. Don't mock Markdown class

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a216620 View commit details
    Browse the repository at this point in the history

  14. Add missing assertions

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5bcb54d View commit details
    Browse the repository at this point in the history

  15. Clear resolved Blade instances

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    bfa129c View commit details
    Browse the repository at this point in the history

  16. Revert "Clear resolved Blade instances" 

    This reverts commit bfa129c.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6288483 View commit details
    Browse the repository at this point in the history

  17. Remove Blade mocks

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    852cb99 View commit details
    Browse the repository at this point in the history

  18. Revert "Remove Blade mocks" 

    This reverts commit 852cb99.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    60c2134 View commit details
    Browse the repository at this point in the history

  19. Swap Blade for a mock

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    bd04137 View commit details
    Browse the repository at this point in the history

  20. Refactor to extract helper method

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2661b8e View commit details
    Browse the repository at this point in the history

  21. Refactor with GPT 4 to use the added helper method

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d950c90 View commit details
    Browse the repository at this point in the history

  22. Move variable assignments inside closures

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5e7869f View commit details
    Browse the repository at this point in the history

  23. Refactor to move Blade mocks into closure

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4868497 View commit details
    Browse the repository at this point in the history

  24. Cleanup formatting

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    45e59ce View commit details
    Browse the repository at this point in the history

  25. Add broader level feature test

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2658708 View commit details
    Browse the repository at this point in the history

  26. Specify page class to use the custom Markdown features

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9f6a579 View commit details
    Browse the repository at this point in the history

  27. Change page class used to render Markdown partials to MarkdownDocument 

    See #1738 (comment)
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f15bea8 View commit details
    Browse the repository at this point in the history

  28. Add test for current state

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9a8538c View commit details
    Browse the repository at this point in the history

  29. Do not inject Torchlight attribution for included partials 

    See #1738 (comment)
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    83c6136 View commit details
    Browse the repository at this point in the history

  30. Clean up formatting

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e56494d View commit details
    Browse the repository at this point in the history

  31. Move up test in source

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9d4a85b View commit details
    Browse the repository at this point in the history

  32. Update RELEASE_NOTES.md

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0225edd View commit details
    Browse the repository at this point in the history

  33. Extract helper method

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b7a7a79 View commit details
    Browse the repository at this point in the history

  34. Test advanced Blade partial is compiled to HTML

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5c1833e View commit details
    Browse the repository at this point in the history

  35. Remove link include requiring more setup

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0127802 View commit details
    Browse the repository at this point in the history

  36. Clean up whitespace

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1d25d01 View commit details
    Browse the repository at this point in the history

  37. Test includes usage from Blade view 

    Emulates the actual usage of the Includes facade from a Blade view
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ffc8e7d View commit details
    Browse the repository at this point in the history

  38. Test without extensions

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b642920 View commit details
    Browse the repository at this point in the history

  39. Add element to match others

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f6d9755 View commit details
    Browse the repository at this point in the history

  40. Clarify the test data

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b207e9b View commit details
    Browse the repository at this point in the history

  41. Reorder lines

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2d8a349 View commit details
    Browse the repository at this point in the history

  42. Document the associated PR

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1365f1c View commit details
    Browse the repository at this point in the history

  43. Trim trailing whitespace from included Markdown 

    To normalize with the Blade and Html includes
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9cc70f6 View commit details
    Browse the repository at this point in the history

  44. Clarify how the test works

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    eeb1fe4 View commit details
    Browse the repository at this point in the history

  45. Add cases for the current escape state

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e9b877a View commit details
    Browse the repository at this point in the history

  46. Extra comment clarification

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6f656e4 View commit details
    Browse the repository at this point in the history

  47. Update Includes helpers to return HtmlString objects 

    Fixes #1734
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    cc33174 View commit details
    Browse the repository at this point in the history

  48. Replace ternary expression with if/else block

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c527e97 View commit details
    Browse the repository at this point in the history

  49. Introduce local variables

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4d44b83 View commit details
    Browse the repository at this point in the history

  50. Wrap declaration in else block

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2282b8e View commit details
    Browse the repository at this point in the history

  51. Unwrap common parts of if/else block

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1e1520a View commit details
    Browse the repository at this point in the history

  52. Unwrap 'else'

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    370524a View commit details
    Browse the repository at this point in the history

  53. Invert control flow to simply conditional paths

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    667f7d9 View commit details
    Browse the repository at this point in the history

  54. Move out return from condition

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6cd529f View commit details
    Browse the repository at this point in the history

  55. Merge into 'elseif'

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    130dd77 View commit details
    Browse the repository at this point in the history

  56. Revert "Merge into 'elseif'" 

    This reverts commit 130dd77.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d0d6709 View commit details
    Browse the repository at this point in the history

  57. Revert "Move out return from condition" 

    This reverts commit 6cd529f.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d248f04 View commit details
    Browse the repository at this point in the history

  58. Revert "Invert control flow to simply conditional paths" 

    This reverts commit 667f7d9.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    dc7c75c View commit details
    Browse the repository at this point in the history

  59. Revert "Unwrap 'else'" 

    This reverts commit 370524a.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    012a91d View commit details
    Browse the repository at this point in the history

  60. Revert "Unwrap common parts of if/else block" 

    This reverts commit 1e1520a.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    de5131e View commit details
    Browse the repository at this point in the history

  61. Revert "Wrap declaration in else block" 

    This reverts commit 2282b8e.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    59448a6 View commit details
    Browse the repository at this point in the history

  62. Revert "Introduce local variables" 

    This reverts commit 4d44b83.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fc6460d View commit details
    Browse the repository at this point in the history

  63. Revert "Replace ternary expression with if/else block" 

    This reverts commit c527e97.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    80e6e1e View commit details
    Browse the repository at this point in the history

  64. Extract helper method to render Markdown

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    66ced70 View commit details
    Browse the repository at this point in the history

  65. Extract helper method to render Blade

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b923262 View commit details
    Browse the repository at this point in the history

  66. Extract helper method to render Html 

    Literally just for matching the code style
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8d7b1cb View commit details
    Browse the repository at this point in the history

  67. Refactor control flow

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9038ab0 View commit details
    Browse the repository at this point in the history

  68. Unwrap 'else'

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e120ba3 View commit details
    Browse the repository at this point in the history

  69. Revert "Unwrap 'else'" 

    This reverts commit e120ba3.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c0efe45 View commit details
    Browse the repository at this point in the history

  70. Revert "Refactor control flow" 

    This reverts commit 9038ab0.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    760af6b View commit details
    Browse the repository at this point in the history

  71. Extract helper to get file contents

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ac255ee View commit details
    Browse the repository at this point in the history

  72. Return null if file does not exist

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    20f764a View commit details
    Browse the repository at this point in the history

  73. Introduce local variable

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b1ad1fc View commit details
    Browse the repository at this point in the history

  74. Check if contents is null

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4ac8f35 View commit details
    Browse the repository at this point in the history

  75. Replace ternary expression with if/else block

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    01d8833 View commit details
    Browse the repository at this point in the history

  76. Set contents to default

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7eb2dab View commit details
    Browse the repository at this point in the history

  77. Unwrap 'else'

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    dae62ba View commit details
    Browse the repository at this point in the history

  78. Flatten nested conditions

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a62671d View commit details
    Browse the repository at this point in the history

  79. Null coalesce to default

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c2b9f68 View commit details
    Browse the repository at this point in the history

  80. Inline local variable

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    dfdceb3 View commit details
    Browse the repository at this point in the history

  81. Revert "Inline local variable" 

    This reverts commit dfdceb3.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0e6b17f View commit details
    Browse the repository at this point in the history

  82. Refactor other methods to use improved control flow

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    456bf34 View commit details
    Browse the repository at this point in the history

  83. Extract helper method for shared code

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    acbe58b View commit details
    Browse the repository at this point in the history

  84. Move up method parameter in signature

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    877aa04 View commit details
    Browse the repository at this point in the history

  85. Use callable method parameter 

    Gets better IDE support and doesn't report the methods as unused
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5fc1c1c View commit details
    Browse the repository at this point in the history

  86. Reorder methods in source 

    Matches the execution flow and documentation order
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6b8e328 View commit details
    Browse the repository at this point in the history

  87. Make extension optional

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    64eb92a View commit details
    Browse the repository at this point in the history

  88. Shift absolute path qualification to retrieval 

    Will prevent recursion issue in upcoming change
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ea93261 View commit details
    Browse the repository at this point in the history

  89. Introduce local variable

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    83b2480 View commit details
    Browse the repository at this point in the history

  90. Revert "Introduce local variable" 

    This reverts commit 83b2480.
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    76b35dc View commit details
    Browse the repository at this point in the history

  91. Shift absolute path qualification to calling method 

    Also reduces unnecessary double qualification attempt in the get method
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c77d1fc View commit details
    Browse the repository at this point in the history

  92. Normalize includes paths using same rules as other helpers 

    This means that nested directories are no longer supported, as you should use a data collection for that. See https://github.com/hydephp/develop/pull/1738/files#r1655369910
    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    11a6015 View commit details
    Browse the repository at this point in the history

  93. Normalize control flow

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9a07581 View commit details
    Browse the repository at this point in the history

  94. Move extension to last in signature

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    15472ec View commit details
    Browse the repository at this point in the history

  95. Make extension optional

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    92fe45d View commit details
    Browse the repository at this point in the history

  96. Union type null instead of nullable short syntax

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1c010cd View commit details
    Browse the repository at this point in the history

  97. Add no-op helper method

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    22c16d2 View commit details
    Browse the repository at this point in the history

  98. Union type string return

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    daedfdf View commit details
    Browse the repository at this point in the history

  99. Use the helper method

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7a7d9db View commit details
    Browse the repository at this point in the history

  100. Annotate callable generics

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    289ae7f View commit details
    Browse the repository at this point in the history

  101. Fix parameter annotation formatting

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    12d845e View commit details
    Browse the repository at this point in the history

  102. Inline no-op helper method into arrow function

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    36e8b5e View commit details
    Browse the repository at this point in the history

  103. Replace ternary expression with if/else block

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    cdcf30e View commit details
    Browse the repository at this point in the history

  104. Unwrap else block

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f30d834 View commit details
    Browse the repository at this point in the history

  105. Remove null union from callable that should not return it

    @caendesilva
    caendesilva committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    befd302 View commit details
    Browse the repository at this point in the history