[2.x] Breaking: Improve the new Authors API #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
caendesilva
commented
Jul 7, 2024
•
caendesilva
commented
- Fixes Support setting authors in the YAML configuration #1719
- Fixes Improve the author feature to allow more schema fields #1778
- Fixes [2.x] Find a better way to reduce author username duplication #1797
caendesilva
force-pushed
the
reduce-author-username-duplication
branch
2 times, most recently
from
f4ec5a5
to
27386ba
Compare
Updates to use the new format specified in #1782
Normalizes the API
caendesilva
force-pushed
the
reduce-author-username-duplication
branch
from
27386ba
to
95d01b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev hydephp/develop#1798 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1838 1842 +4
===========================================
Files 188 188
Lines 4862 4877 +15
===========================================
+ Hits 4862 4877 +15 ☔ View full report in Codecov by Sentry. |
Enforces the new state. Consider adding a BadConfigurationException?
This leads to duplication which gets confusing
caendesilva
force-pushed
the
reduce-author-username-duplication
branch
from
5e000ad
to
fbfa507
Compare
If we can't find the line, it's probably because an internal/package developer made a mistake
caendesilva
force-pushed
the
reduce-author-username-duplication
branch
from
f9a9ebe
to
81fc538
Compare
caendesilva
force-pushed
the
reduce-author-username-duplication
branch
from
81fc538
to
ba2a352
Compare
caendesilva
force-pushed
the
reduce-author-username-duplication
branch
from
eda0c62
to
50de689
Compare
caendesilva
force-pushed
the
reduce-author-username-duplication
branch
from
4f6a195
to
f317b2d
Compare
caendesilva
force-pushed
the
reduce-author-username-duplication
branch
2 times, most recently
from
ba1c18b
to
eebecc9
Compare
caendesilva
force-pushed
the
reduce-author-username-duplication
branch
from
eebecc9
to
5fda706
Compare
caendesilva
commented
Jul 9, 2024
Comment on lines
+291
to
+299
|
|
||
| // The following settings are not used in the bundled templates, | ||
| // but you can use them in your own custom views, for example. | ||
| // bio: 'The mysterious author of HydePHP', | ||
| // avatar: 'avatar.png', | ||
| // socials: [ | ||
| // 'twitter' => 'HydeFramework', | ||
| // 'github' => 'hydephp', | ||
| // ], |
There was a problem hiding this comment.
Maybe we do not need this here, as they are not yet used, and they are in the documentation. However, if https://github.com/hydephp/develop/issues/1762 will use these they can be kept, hence why I'm holding off on removing them.
caendesilva
added a commit
that referenced
this pull request
Jul 9, 2024
[2.x] Breaking: Improve the new Authors API
caendesilva
added a commit
that referenced
this pull request
Jul 9, 2024
[2.x] Breaking: Improve the new Authors API
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.