[2.x] Revert to throwing an exception when trying to get non-configured base URL #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
force-pushed
the
revert-to-throwing-when-trying-to-get-unconfigured-base-url
branch
from
aa15d79
to
790654c
Compare
caendesilva
added a commit
that referenced
this pull request
Jul 23, 2024
Updates for the new changes in #1890
caendesilva
pushed a commit
to hydephp/framework
that referenced
this pull request
Jul 23, 2024
Updates for the new changes in hydephp/develop#1890 hydephp/develop@e9778a9
caendesilva
deleted the
revert-to-throwing-when-trying-to-get-unconfigured-base-url
branch
caendesilva
pushed a commit
to hydephp/framework
that referenced
this pull request
Jul 23, 2024
Updates for the new changes in hydephp/develop#1890 hydephp/develop@e9778a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the unreleased behaviour where this returns null. Returning null for a fault path means the developer needs to check for null types, but that solves the problem. If the developer cares about site URLs they need to set the site URL, and having a null that can silently be ignored is unintuitive. If the user tries to get a base URL and one is not set, that's a bug, and throwing an exception alerts them of it. It is not justified to have the custom exception for this, so that is still removed, and we now throw a BadMethodCallException instead. This essentially reverts most of #1760. See tie in with e9778a9