Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gender presentation pride flags #32

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Conversation

ngkz
Copy link

@ngkz ngkz commented Oct 30, 2022

Description

Add gender non-conforming, femboy and tomboy flags

Features

Issues

  • Some colors of GNC and tomboy flags are off
  • two purples of the GNC flag are hard to distinguish

TODO

@hykilpikonna
Copy link
Owner

Thank you for the PR!

The flags look good on the preview page, but due to color lightness adjustments, the two purples look kind of the same.

image

image

However, since the lightness range between the brightest and dimmest colors is too wide, lightness adjustment is necessary (or else it would look like the below screenshot where the dark purple isn't really visible on dark terminal, and the white wouldn't be visible on light terminals.

image

image

I'll merge this for now, even though the colors will look like this until we have a better way of addressing the lightness issue.

@hykilpikonna hykilpikonna merged commit e49ed7d into hykilpikonna:master Oct 30, 2022
teohhanhui added a commit to teohhanhui/hyfetch that referenced this pull request Jul 20, 2024
Support foreground-background for vertical color alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants