-
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
34 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# Summary | ||
|
||
<!-- Please tell us what your pull request is about here. --> | ||
|
||
|
||
# Pull Request Check List | ||
|
||
<!-- | ||
This is just a friendly reminder about the most common mistakes. | ||
Please make sure that you tick all boxes. | ||
But please read our [contribution guide](https://github.com/hynek/stamina/blob/main/.github/CONTRIBUTING.md) at least once; it will save you unnecessary review cycles! | ||
If an item doesn't apply to your pull request, **check it anyway** to make it apparent that there's nothing left to do. | ||
--> | ||
|
||
- [ ] Do **not** open pull requests from your main branch, but **use a branch instead**. There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the PR from the new branch. | ||
|
||
This is not a pre-requisite for your your pull request to be accepted, but **you have been warned**. | ||
- [ ] Added **tests** for changed code. | ||
- The CI fails with less than 100% coverage. | ||
- [ ] **New APIs** are added to our typing tests in [`api.py`](https://github.com/hynek/stamina/blob/main/tests/typing/api.py). | ||
- [ ] Updated **documentation** for changed code. | ||
- [ ] New functions/classes have to be added to `docs/api.md` by hand. | ||
- [ ] Changed/added classes/methods/functions have appropriate `versionadded`, `versionchanged`, or `deprecated` [directives](http://www.sphinx-doc.org/en/stable/markup/para.html#directive-versionadded). | ||
|
||
The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 23.1.0, the next version is gonna be 23.2.0. If the next version is the first in the new year, it'll be 24.1.0. | ||
- [ ] Documentation in `.md` files is written using [**semantic newlines**](https://rhodesmill.org/brandon/2012/one-sentence-per-line/). | ||
- [ ] Changes (and possible deprecations) are documented in the [**changelog**](https://github.com/hynek/stamina/blob/main/CHANGELOG.md). | ||
- [ ] Consider granting [push permissions to the PR branch](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork), so maintainers can fix minor issues themselves without pestering you. | ||
|
||
<!-- | ||
If you have *any* questions to *any* of the points above, just **submit and ask**! | ||
This checklist is here to *help* you, not to deter you from contributing! | ||
--> |