On predicate

[gsakkis]

Allow on to be a predicate

[hynek]

@dhirschfeld @estahn Before I dive into this¹ – opinions?

Footnotes

1. I really need to get out attrs 24.1 before starting something new 🫠 ↩

[dhirschfeld]

I'm not a big fan of the name. on: On doesn't convey any meaning to the reader of the code.

My own inclination would be to try and give some meaning to the name - e.g. on: exc_or_predicate. It's not perfect, but I think it's probably better than conveying no meaning in the name.

[gsakkis]

Renamed to ExcOrPredicate

[dhirschfeld]

Just some stylistic comments which @hynek can decide upon, otherwise I think it looks good.

[dhirschfeld]

Resolves #63

[estahn]

Does this need documentation or an example for the docs?

[hynek]

Does this need documentation or an example for the docs?

impeccable timing :D

[hynek]

I've just added the docs and am heading to the gym. If y'all could have look at them until I'm back that would be appreciated: https://py-stamina--70.org.readthedocs.build/en/70/

[estahn]

I've just added the docs and am heading to the gym. If y'all could have look at them until I'm back that would be appreciated: https://py-stamina--70.org.readthedocs.build/en/70/

Looks good to me, although I realise it doesn't fully support my use-case I think.

We integrate with a large number of different API vendors and each have their own quirks. One of them being the handling of quota's. Some of those API's will respond with a 429 and provide quota details like time to next retry. I figured I could use this information as the basis for the retry mechanics, but wait is not a callable.

Similar to this example.
https://www.seelk.co/blog/efficient-client-side-handling-of-api-throttling-in-python-with-tenacity/

As for this PR 👍🏼 🚀

[hynek]

I realise it doesn't fully support my use-case I think.

We integrate with a large number of different API vendors and each have their own quirks. One of them being the handling of quota's. Some of those API's will respond with a 429 and provide quota details like time to next retry. I figured I could use this information as the basis for the retry mechanics, but wait is not a callable.

So what you want is being about to return a float that means "yes, but at least this long"?

Feel free to open a discussion about it, ideally with a simplified requirement vs whole blog post. 😇

As for this PR 👍🏼 🚀

Thanks!

[estahn]

@hynek Thanks for merging. Is there anything else required before releasing this?

[hynek]

yes, since I work in batches, I want to tackle #71 and #59 before releasing and moving on (to svcs).