This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Enable PWA Support #163
Merged
Enable PWA Support #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hyochan Please review this PR. Note that I made this branch on top of your branch (not master). |
This is the way to go! You did great |
hyochan
reviewed
Jan 18, 2021
hyochan
approved these changes
Jan 18, 2021
hyochan
added a commit
that referenced
this pull request
Jan 31, 2021
* Configure react-native-web in project * Configured projects with all 3 platforms They almost look a like now. However still on more remaining issue is `fbt`. * Removed react-app-rewired and added craco * Fixed tests with correct fbtEnum path There was a space at the first of the path strings * More options to tsconfig * Fixed fbt for android * Refactor codes applying new eslint rules * Upgrade typescript to < 4.1 and > 3.9 Affected by the peer dep * Configured eslint rules * More lint fixes * Fixed false positiy eslint config upgrading package * Mocked @react-navigation/stack * Updated snapshots * Updated packages * Added v5 tag for dooboo-cli@5 compatibility Refer to hyochan/dooboo-cli#75 * TS config isolatedModules => false eveningkid/denodb#146 * More lint fixes in root files * Set isolatedModules to true for in tsconfig * Generated fbts * Added `withScreen` util instead of wrapping whole screen * Remove i18n root which is moved to utils * Updated [ThemeProvider] and changed theme controls * Patch on new themeing and media queries * Updated button text color * Enable PWA Support (#163) * Updated packages and eslint config * Removed empty spaces in .gitignore * Removed generated i18n files from git * Update packages * Upgrade android sdk version to 29 * Circleci android sdk 29 image Co-authored-by: Donghyeon Kim <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
public/service-worker.js.src/index.tsx.Notes
This PR is made on top of #162