This repository has been archived by the owner on May 31, 2021. It is now read-only.
Bugfix/remove linter erros #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffGuKang
suggested changes
Sep 13, 2020
There was a problem hiding this comment.
DatePicker is waiting the PR related to #337. So how about dealing with only Badges here?
main/Badge/index.tsx
Outdated
| @@ -22,38 +24,44 @@ export interface BadgeProps extends StyleProps{ | |||
| const StyledView = styled.View<StyleProps>` | |||
| position: absolute; | |||
| top: -15px; | |||
| ${(props) => props.badgePlacement}: -10px; | |||
|
|
|||
There was a problem hiding this comment.
Meaningless empty line.
There was a problem hiding this comment.
thk u for comment! resolved in 4330880
main/Badge/index.tsx
Outdated
| @@ -1,7 +1,9 @@ | |||
| import React, { FC } from 'react'; | |||
|
|
|||
There was a problem hiding this comment.
resolved in 4330880
Sounds great! i reverted commits about DatePicker |
|
@greatSumini Good! Could you update a doc? Cause |
resolved in 62b32b7 😄 |
JeffGuKang
approved these changes
Sep 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove linter errors, update snapshots for Badge, DatePicker component
Related Issues
x
Tests
I added the following tests:
x
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn testoryarn test -uif you need to update snapshot.yarn lint