Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

test: set standard date for date values used by DatePicker #340

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

oh3vci
Copy link
Contributor

@oh3vci oh3vci commented Sep 13, 2020

Description

Because the new Date changed the date value each time the date changes, Test snapshots don't be matched.
So, I set the standard date merged DatePicker to dooboo-ui.

Related Issues

#337

Tests

just jest test

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test or yarn test -u if you need to update snapshot.
  • Run yarn lint
  • I am willing to follow-up on review comments in a timely manner.

- The standard date is the date merged DatePicker to dooboo-ui
@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #340 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files          37       37           
  Lines        1218     1218           
  Branches      367      367           
=======================================
  Hits         1014     1014           
  Misses         89       89           
  Partials      115      115           

@bumjoo
Copy link
Contributor

bumjoo commented Sep 13, 2020

Good job~!! Thanks.

Copy link
Collaborator

@JeffGuKang JeffGuKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeffGuKang JeffGuKang merged commit ba3a95b into hyochan:master Sep 13, 2020
@oh3vci oh3vci deleted the test/datepicker branch September 13, 2020 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants