Remove Bytes from the public API #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
try-shared
branch
from
84ce231
to
d9b7950
Compare
|
Is the idea that the next release of |
|
I'm strongly considering it, or otherwise a 0.2 meant as a preview of 1.0 just to check the new changes. |
seanmonstar
force-pushed
the
try-shared
branch
from
d9b7950
to
566878e
Compare
LucioFranco
reviewed
Dec 2, 2019
|
I'm also happy to go 1.0 with http |
Removes `from_shared` and `try_from` constructors for all types.
We reserved these extra error types with the goal of possibly returning the source `Bytes` in the error type, but no one has since need this. Since the dependency on `bytes` is being made private, it made sense to remove these otherwise unused error types. Removes: - `InvalidUriBytes` - `InvalidHeaderNameBytes` - `InvalidHeaderValueBytes`
These constructors don't expose the internal `Bytes` type, but instead will try to downcast the argument to prevent a copy. If the types don't match up (a user provides an older version of `Bytes`), the value will just be copied. Adds: - `HeaderValue::from_maybe_shared` - `HeaderValue::from_maybe_shared_unchecked` - `Uri::from_maybe_shared` - `Authority::from_maybe_shared` - `PathAndQuery::from_maybe_shared`
seanmonstar
force-pushed
the
try-shared
branch
from
566878e
to
588bc3b
Compare
carllerche
approved these changes
Dec 2, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove
Bytesfrom the public API while it is unstable, and addsfrom_maybe_sharedgeneric constructors that can allow improved performance (less copies) if the correct version ofBytesis used.Closes #366