Skip to content

Commit

Permalink
fix(net): ignore NotConnected error in NetworkStream.close
Browse files Browse the repository at this point in the history
On OSX, calling shutdown a second time will return a NotConnected error.
This commit will just ignore it, since we can agree that if a stream is
"not connected", it is in fact "closed".

Closes #508
  • Loading branch information
seanmonstar committed May 7, 2015
1 parent 67340a5 commit 6be6005
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions src/net.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! A collection of traits abstracting over Listeners and Streams.
use std::any::{Any, TypeId};
use std::fmt;
use std::io::{self, Read, Write};
use std::io::{self, ErrorKind, Read, Write};
use std::net::{SocketAddr, ToSocketAddrs, TcpStream, TcpListener, Shutdown};
use std::mem;
use std::path::Path;
Expand Down Expand Up @@ -292,10 +292,21 @@ impl NetworkStream for HttpStream {

#[inline]
fn close(&mut self, how: Shutdown) -> io::Result<()> {
#[inline]
fn shutdown(tcp: &mut TcpStream, how: Shutdown) -> io::Result<()> {
match tcp.shutdown(how) {
Ok(_) => Ok(()),
// see https://github.com/hyperium/hyper/issues/508
Err(ref e) if e.kind() == ErrorKind::NotConnected => Ok(()),
err => err
}
}

match *self {
HttpStream::Http(ref mut inner) => inner.0.shutdown(how),
HttpStream::Https(ref mut inner) => inner.get_mut().0.shutdown(how)
HttpStream::Http(ref mut inner) => shutdown(&mut inner.0, how),
HttpStream::Https(ref mut inner) => shutdown(&mut inner.get_mut().0, how)
}

}
}

Expand Down

0 comments on commit 6be6005

Please sign in to comment.