Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close a keep-alive connection on 204 (No Content) Response from server #1242

Closed
lumasepa opened this issue Jul 4, 2017 · 1 comment
Labels
A-client Area: client. C-bug Category: bug. Something is wrong. This is bad!

Comments

@lumasepa
Copy link

lumasepa commented Jul 4, 2017

Right now Hyper closes the connection when the server responds with status code 204 and the connection have the keep-alive header and the client have the keep-alive setting. This is a problem because even if the server says that there is no content the client may want to request more resources

Finagle had the same problem, for reference twitter/finagle#563.

@seanmonstar seanmonstar added C-bug Category: bug. Something is wrong. This is bad! A-client Area: client. labels Jul 4, 2017
@seanmonstar
Copy link
Member

Thanks for the report! There used to be code to properly handle 204s and 304s, but it was lost in the redesign to async. I'm adding it back in. The fix will be included when 0.11.2 is released.

yazaddaruvala pushed a commit to yazaddaruvala/hyper that referenced this issue Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client. C-bug Category: bug. Something is wrong. This is bad!
Projects
None yet
Development

No branches or pull requests

2 participants