Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conn should call shutdown on the inner stream when dropping #1380

Closed
sfackler opened this issue Nov 21, 2017 · 3 comments
Closed

Conn should call shutdown on the inner stream when dropping #1380

sfackler opened this issue Nov 21, 2017 · 3 comments
Labels
A-client Area: client. C-bug Category: bug. Something is wrong. This is bad!

Comments

@sfackler
Copy link
Contributor

This is pretty important for TLS connections so that they can perform the TLS connection shutdown messaging to allow for session reuse.
sfackler added a commit to sfackler/hyper that referenced this issue Nov 22, 2017
@sfackler
Shut down the connection when done with it
a356449 
This is important for TLS connections in particular

Closes hyperium#1380
@sfackler sfackler mentioned this issue Nov 22, 2017
Merged
seanmonstar pushed a commit that referenced this issue Nov 28, 2017
@sfackler @seanmonstar
fix(server): allow TLS shutdown before dropping connections with no_p…
60d0eaf 
…roto

This is important for TLS connections in particular

Closes #1380
@sfackler
Copy link
Contributor Author

@seanmonstar could you reopen? We still need to handle the client side.

@seanmonstar seanmonstar reopened this Nov 28, 2017
@seanmonstar seanmonstar added A-client Area: client. C-bug Category: bug. Something is wrong. This is bad! labels Dec 7, 2017
@seanmonstar
Copy link
Member

To clarify, is there a situation in the client where this doesn't happen? It look like in Dispatcher::poll, shutdown is called before returning Async::Ready(()) in all cases.

@sfackler
Copy link
Contributor Author

sfackler commented Jan 8, 2018

Yep, looks like it is!

@sfackler sfackler closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: client. C-bug Category: bug. Something is wrong. This is bad!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @sfackler