Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try parsing HTTP2 on server connections if HTTP1 parsing fails #1486

Closed
seanmonstar opened this issue Apr 13, 2018 · 3 comments
Closed

Try parsing HTTP2 on server connections if HTTP1 parsing fails #1486

seanmonstar opened this issue Apr 13, 2018 · 3 comments
Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.

Comments

@seanmonstar
Copy link
Member

This would be a next step to allowing the server to have HTTP2 support on by default.
@seanmonstar seanmonstar added A-server Area: server. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful. labels Apr 13, 2018
@estk
Copy link
Contributor

estk commented Apr 23, 2018

I'd like to take this one on.

@seanmonstar
Copy link
Member Author

@estk cool!

I haven't personally thought out an exact implementation yet... One way could be for server::conn::Connection to be able to inspect a returned error, and if it's a parse error, try to take the IO and read buffer back out and use them to try the h2::server::handshake...

@estk
Copy link
Contributor

estk commented Apr 23, 2018

Excellent thanks for the head start.

@estk estk mentioned this issue Apr 27, 2018
Merged
5 tasks
seanmonstar pushed a commit that referenced this issue May 10, 2018
@estk @seanmonstar
feat(server): support HTTP1 and HTTP2 automatically
bc6af88 
If an HTTP/1 connection has a parse error, but it starts with the HTTP2 preface, converts the connection automatically into an HTTP2 server connection.

Closes #1486
ernestas-poskus pushed a commit to ernestas-poskus/hyper that referenced this issue May 11, 2018
@estk @ernestas-poskus
feat(server): support HTTP1 and HTTP2 automatically
d8be39c 
If an HTTP/1 connection has a parse error, but it starts with the HTTP2 preface, converts the connection automatically into an HTTP2 server connection.

Closes hyperium#1486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @estk