Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a Resolver that uses tokio-threadpool::blocking instead of futures-cpupool #1676

Closed
seanmonstar opened this issue Oct 18, 2018 · 1 comment · Fixed by #1678
Closed

Consider a Resolver that uses tokio-threadpool::blocking instead of futures-cpupool #1676

seanmonstar opened this issue Oct 18, 2018 · 1 comment · Fixed by #1678
Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

Using tokio_threadpool::blocking can reduce some overhead, and make resolving use an existing threadpool instead of needing a separate dedicated one. It can't be the default, since it only works if the executor is tokio_threadpool, whereas the futures_cpupool resolver works with any executor, but it'd be nice (and easy) to offer it.
@seanmonstar seanmonstar added A-client Area: client. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. labels Oct 18, 2018
@seanmonstar
Copy link
Member Author

cc @sfackler

sfackler added a commit to sfackler/hyper that referenced this issue Oct 20, 2018
@sfackler
feat(dns): tokio_threadpool::blocking resolver
106b904 
Unlike the default resolver, this avoids spawning extra dedicated
threads but only works on the multi-threaded Tokio runtime.

Closes hyperium#1676
@sfackler sfackler mentioned this issue Oct 20, 2018
Merged
seanmonstar pushed a commit that referenced this issue Oct 23, 2018
@sfackler @seanmonstar
feat(dns): tokio_threadpool::blocking resolver
1e8d643 
Unlike the default resolver, this avoids spawning extra dedicated
threads but only works on the multi-threaded Tokio runtime.

Closes #1676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dns): tokio_threadpool::blocking resolver sfackler/hyper
1 participant
@seanmonstar