Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a Connection Pool to the Client #363

Closed
seanmonstar opened this issue Mar 7, 2015 · 3 comments · Fixed by #486
Closed

add a Connection Pool to the Client #363

seanmonstar opened this issue Mar 7, 2015 · 3 comments · Fixed by #486
Labels
A-client Area: client.

Comments

@seanmonstar
Copy link
Member

Some notes:

  • There should be a trait, such that others can create a specialized pool if they want
  • must keep in mind that Client supports custom NetworkConnectors
@seanmonstar seanmonstar added the A-client Area: client. label Mar 7, 2015
@andydude
Copy link

andydude commented Mar 7, 2015

I would like to help with this.

@seanmonstar
Copy link
Member Author

cc @jamwt

@seanmonstar
Copy link
Member Author

blocks #41

seanmonstar added a commit that referenced this issue Apr 28, 2015
@seanmonstar
feat(client): add a Connection Pool
1f0d3db 
This adds a connection pool to the Client that is used by default. It
accepts any other NetworkConnector, and simply acts as a
NetworkConnector itself. Other Pools can exist by simply providing a
custom NetworkConnector. This Pool is only used by default if you also
use the default connector, which is `HttpConnector`. If you wish to use
the Pool with a custom connector, you'll need to create the Pool with
your custom connector, and then pass that pool to the
Client::with_connector.

This also adds a method to `NetworkStream`, `close`, which can be used
to know when the Stream should be put down, because a server requested
that the connection close instead of be kept alive.

Closes #363
Closes #41
@seanmonstar seanmonstar mentioned this issue Apr 28, 2015
Merged
seanmonstar added a commit that referenced this issue Apr 28, 2015
@seanmonstar
feat(client): add a Connection Pool
5d6e95a 
This adds a connection pool to the Client that is used by default. It
accepts any other NetworkConnector, and simply acts as a
NetworkConnector itself. Other Pools can exist by simply providing a
custom NetworkConnector. This Pool is only used by default if you also
use the default connector, which is `HttpConnector`. If you wish to use
the Pool with a custom connector, you'll need to create the Pool with
your custom connector, and then pass that pool to the
Client::with_connector.

This also adds a method to `NetworkStream`, `close`, which can be used
to know when the Stream should be put down, because a server requested
that the connection close instead of be kept alive.

Closes #363
Closes #41
seanmonstar added a commit that referenced this issue Apr 28, 2015
@seanmonstar
feat(client): add a Connection Pool
e9c7133 
This adds a connection pool to the Client that is used by default. It
accepts any other NetworkConnector, and simply acts as a
NetworkConnector itself. Other Pools can exist by simply providing a
custom NetworkConnector. This Pool is only used by default if you also
use the default connector, which is `HttpConnector`. If you wish to use
the Pool with a custom connector, you'll need to create the Pool with
your custom connector, and then pass that pool to the
Client::with_connector.

This also adds a method to `NetworkStream`, `close`, which can be used
to know when the Stream should be put down, because a server requested
that the connection close instead of be kept alive.

Closes #363
Closes #41
seanmonstar added a commit that referenced this issue Apr 29, 2015
@seanmonstar
feat(client): add a Connection Pool
1e72a8a 
This adds a connection pool to the Client that is used by default. It
accepts any other NetworkConnector, and simply acts as a
NetworkConnector itself. Other Pools can exist by simply providing a
custom NetworkConnector. This Pool is only used by default if you also
use the default connector, which is `HttpConnector`. If you wish to use
the Pool with a custom connector, you'll need to create the Pool with
your custom connector, and then pass that pool to the
Client::with_connector.

This also adds a method to `NetworkStream`, `close`, which can be used
to know when the Stream should be put down, because a server requested
that the connection close instead of be kept alive.

Closes #363
Closes #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: client.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client): add a Connection Pool hyperium/hyper
2 participants
@andydude @seanmonstar