Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an Ssl variant to Error #483

Closed
seanmonstar opened this issue Apr 27, 2015 · 0 comments · Fixed by #506
Closed

Add an Ssl variant to Error #483

seanmonstar opened this issue Apr 27, 2015 · 0 comments · Fixed by #506
Labels
A-client Area: client.

Comments

@seanmonstar
Copy link
Member

And change NetworkConnector::connect to return a HttpError instead of an IoError. The SSL errors are being boxed into an ErrorKind::Other, currently, which is losing information.
@seanmonstar seanmonstar added A-client Area: client. servo labels Apr 27, 2015
seanmonstar added a commit that referenced this issue May 5, 2015
@seanmonstar
feat(error): add Ssl variant to hyper::Error
ae856e7 
The errors from openssl were previously boxed into a
Box<std::error::Error>, which lost some specifics and made it difficult
to match against. To solve this, an `Ssl` variant is added to the
`Error` enum of hyper, and is returned when openssl returns specific
errors.

Closes #483

BREAKING CHANGE: Adds a variant to `hyper::Error`, which may break any
exhaustive matches.
@seanmonstar seanmonstar mentioned this issue May 5, 2015
Merged
seanmonstar added a commit that referenced this issue May 6, 2015
@seanmonstar
feat(error): add Ssl variant to hyper::Error
219fec4 
The errors from openssl were previously boxed into a
Box<std::error::Error>, which lost some specifics and made it difficult
to match against. To solve this, an `Ssl` variant is added to the
`Error` enum of hyper, and is returned when openssl returns specific
errors.

Closes #483

BREAKING CHANGE: Adds a variant to `hyper::Error`, which may break any
exhaustive matches.
seanmonstar added a commit that referenced this issue May 6, 2015
@seanmonstar
feat(error): add Ssl variant to hyper::Error
972b3a3 
The errors from openssl were previously boxed into a
Box<std::error::Error>, which lost some specifics and made it difficult
to match against. To solve this, an `Ssl` variant is added to the
`Error` enum of hyper, and is returned when openssl returns specific
errors.

Closes #483

BREAKING CHANGE: Adds a variant to `hyper::Error`, which may break any
exhaustive matches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: client.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(error): add Ssl variant to hyper::Error hyperium/hyper
1 participant
@seanmonstar