Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_interface connector option #3076

Open
wants to merge 2 commits into
base: 0.14.x
Choose a base branch
from

Conversation

hottea773
Copy link

This PR is a duplicate of #2484 which I'd like to use, but is closed.

(I've minorly changed it such that we bind to the interface before we bind to the address otherwise it can cause issues with failing to find addresses on VRFs.)

I'd like to use it soon, so I've made it against the 0.14.x branch. I hope that's ok?

@hottea773
Copy link
Author

@seanmonstar sorry for the tag, hope you're the right person. Is there any chance this might get looked at any time soon?

@seanmonstar
Copy link
Member

So, while I'm supportive of adding the feature in general, I do feel divided about adding new things to 0.14.x. Ideally (from my point of view), this would land in hyper-util. Is that fine for your use case? It could mean it's a little harder to start using it right away.

@hottea773
Copy link
Author

So, while I'm supportive of adding the feature in general, I do feel divided about adding new things to 0.14.x. Ideally (from my point of view), this would land in hyper-util. Is that fine for your use case? It could mean it's a little harder to start using it right away.

Thanks, that makes sense. I think using the 0.14 fork for a few months should be ok for me. AIUI hyper-util is where this section of code is going in 1.0.0, so if I made this change there we'd be able to use it once that is released?

@hottea773
Copy link
Author

I've opened hyperium/hyper-util#26 which AFAICT essentially re-targets this PR against the v1 branch. If that is approved, I'll close this PR as I'm happy to wait for v1 to use this feature.

@hottea773
Copy link
Author

Since hyperium/hyper-util#26 has been merged, so this will be available from v1 onwards, I'm closing this PR

@hottea773 hottea773 closed this Apr 28, 2023
@nickjknight
Copy link

Since hyper V1 is taking quite a long time. Can we get this useful change applied to 0.14.x as well?

@hottea773
Copy link
Author

hottea773 commented Sep 29, 2023

I'll re-open the PR as I'd be happy for this to be merged into 0.14, but obviously depends on what Sean thinks.

@hottea773 hottea773 reopened this Sep 29, 2023
@hottea773
Copy link
Author

@seanmonstar do you have any views on @nickjknight 's request?

@seanmonstar
Copy link
Member

1.0 target date is Nov 15. That's got all my attention at the moment.

Some back ports after could be fine, we'll see.

@hottea773
Copy link
Author

Hey, thanks. If it is coming next week, then I imagine that should be good for people's use cases. @nickjknight any opinions?

@nickjknight
Copy link

nickjknight commented Nov 10, 2023

Looks like We'd still probably like it back ported once there's a bit of time availble. Our infrastructure will be on 0.14 for a while longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants