-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_interface connector option #3076
base: 0.14.x
Are you sure you want to change the base?
Conversation
@seanmonstar sorry for the tag, hope you're the right person. Is there any chance this might get looked at any time soon? |
So, while I'm supportive of adding the feature in general, I do feel divided about adding new things to 0.14.x. Ideally (from my point of view), this would land in |
Thanks, that makes sense. I think using the |
I've opened hyperium/hyper-util#26 which AFAICT essentially re-targets this PR against the |
Since hyperium/hyper-util#26 has been merged, so this will be available from v1 onwards, I'm closing this PR |
Since hyper V1 is taking quite a long time. Can we get this useful change applied to 0.14.x as well? |
I'll re-open the PR as I'd be happy for this to be merged into |
@seanmonstar do you have any views on @nickjknight 's request? |
1.0 target date is Nov 15. That's got all my attention at the moment. Some back ports after could be fine, we'll see. |
Hey, thanks. If it is coming next week, then I imagine that should be good for people's use cases. @nickjknight any opinions? |
Looks like We'd still probably like it back ported once there's a bit of time availble. Our infrastructure will be on 0.14 for a while longer. |
This PR is a duplicate of #2484 which I'd like to use, but is closed.
(I've minorly changed it such that we bind to the interface before we bind to the address otherwise it can cause issues with failing to find addresses on VRFs.)
I'd like to use it soon, so I've made it against the
0.14.x
branch. I hope that's ok?