feat(server): backport the split server conn modules #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I just reviewed #3101, I'm realizing that probably should be part of the backport too, or else we'll need to have deprecated methods in the backport 😅 |
|
Indeed! I'll incorporate their changes tomorrow. |
Closed
seanmonstar
reviewed
Mar 7, 2023
oddgrd
force-pushed
the
feat/backport-split-server-conn-modules
branch
from
956968e
to
a71c219
Compare
oddgrd
force-pushed
the
feat/backport-split-server-conn-modules
branch
from
a71c219
to
4504698
Compare
…it-server-conn-modules
seanmonstar
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the
server::conn::http1andserver::conn::http2modules to0.14.x. I've drew a lot on the work already done in #3063 (:pray:), but diverged a bit on the feature naming (no strong feelings on this though). I also implemented thedeprecatedfeature flag as was suggested in that PR.I have a couple of questions:
common::time::Timer(as is done in split client conn backports), is that OK or should that module also be backported?I've also only added one deprecation warning so far, but I'll look around and see if more make sense.
Closes #3079